Date: Fri, 14 Apr 2017 16:29:23 -0700 From: Peter Wemm <peter@wemm.org> To: Maxim Sobolev <sobomax@sippysoft.com> Cc: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Hiren Panchasara <hiren@freebsd.org> Subject: Re: svn commit: r316874 - head/sys/kern Message-ID: <3928506.Yjk9xjcQnh@overcee.wemm.org> In-Reply-To: <CAH7qZfvPQpmTkypWdv1K=9yKF6was1sXuXY7McAeTrC8mvYZbg@mail.gmail.com> References: <201704141723.v3EHNS3B043902@repo.freebsd.org> <513B1846-02E3-49E0-BAA2-CA923EDC5DFF@gmail.com> <CAH7qZfvPQpmTkypWdv1K=9yKF6was1sXuXY7McAeTrC8mvYZbg@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Friday, April 14, 2017 02:10:56 PM Maxim Sobolev wrote: > Peter, Ngie, > > Looks like out of that refactoring came a logical bug that is present in > the head, which causes syslod to first to shutdown the socket for reading > and then try to select/recv on it (which is somewhat stupid). And that > issue has been masked by shutdown() on datagram socket becoming effectively > a NOP in 11 & head 20 months ago. It only affects head though, 11-stable > still has the old code which does not include that half-closed socket into > the select list. Attached patch is expected to fix head, Peter, it would be > nice if you can give it a try (restoring latest changes into > uipc_sockets.c) and let me know if it helps. Confirmed - resting uipc_socket.c to HEAD and applying the patch to syslogd does solve the problem we encountered. Thanks! > Thanks! > > On Fri, Apr 14, 2017 at 12:48 PM, Ngie Cooper (yaneurabeya) < > > yaneurabeya@gmail.com> wrote: > > > On Apr 14, 2017, at 12:46, Peter Wemm <peter@wemm.org> wrote: > > > > > > On Friday, April 14, 2017 12:41:52 PM Maxim Sobolev wrote: > > >> Thanks, Peter. I will try to look into this asap. > > > > > > I don't understand what is going on yet. Presumably there must be other > > > changes in play that affect udp/select sometime between the original > > > 2015 > > > change and this. The syslogd -s code is Old(TM). I'm also wondering > > > > whether > > > > > the -s code even works at all since the 2015 / r285910 change... > > > > syslogd has been refactored a lot on ^/head. I don’t think it’s safe to > > say that the ^/head and ^/stable/11 and earlier copies will function the > > same. > > Thanks, > > -Ngie -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV UTF-8: for when a ' or ... just won\342\200\231t do\342\200\246 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEBgrA0Vr/vfNVuPoUNdaXCeyAngQFAljxW1MACgkQNdaXCeyA ngTWkQf+O4ofbVLIQ6jlydSdqRO5AgThl07dr4cjRUMzZzldtqkjj/Zk5/SvvvwS 82aYqorZfxapvJIz13Vw0QXIJPeZbWII805+6KACbmWMkqYk9bNC/FhO0NKbfDeq wH/138PvFA6iyDhTmqknvLVyjvJFElanVJB6bLbBpcTAVqSqjyhJ5EyKYlZotscO ciP3yRxHRDKmhfsOsgG3PSIw48e1PR/KJmuYrnFb1UigEXFV35yonMxebPZbHIHQ oLWbk1re3oxGYoQYn7ZMk93O2wqohCR7HjOKOILIKNOCI5mhmz7JiKrPADUqr98e hfWEIR7+2IWPj0c9RMmbnUuIk1ZDkQ== =VKpE -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3928506.Yjk9xjcQnh>