Date: Fri, 12 Aug 2016 22:35:39 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Ed Schouten <ed@nuxi.nl> Cc: Ngie Cooper <yaneurabeya@gmail.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304011 - head/libexec/rtld-elf Message-ID: <20160812193539.GR83214@kib.kiev.ua> In-Reply-To: <CABh_MK=RT=1rm_RDY3-9eoYiybfwmHEeU_DRvOuNnTpPV_R0Fg@mail.gmail.com> References: <201608121829.u7CITCIu059447@repo.freebsd.org> <35B0B56E-A536-4A07-B397-7E5ABAB4CB34@gmail.com> <20160812183636.GP83214@kib.kiev.ua> <CABh_MK=RT=1rm_RDY3-9eoYiybfwmHEeU_DRvOuNnTpPV_R0Fg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 12, 2016 at 09:32:37PM +0200, Ed Schouten wrote: > 2016-08-12 20:36 GMT+02:00 Konstantin Belousov <kostikbel@gmail.com>: > > Because the API is unusable. It causes full queue iteration when the object > > is NULL, i.e. at the end of the queue, instead of doing nothing. > > Ah, thanks for working on this then. I personally think that all of > those macros in <sys/queue.h> that run in linear time should be > removed. Why not just use the proper data structure? What is improper about the tail-queue for global object list ? Typical operations with it involve all objects in the list. The only special ops I am aware are lookups by name or by dev_t/inode, but having the parallel (two) maps there is overkill.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160812193539.GR83214>