Date: Tue, 26 Nov 2013 09:39:58 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Erwin Lansing <erwin@FreeBSD.org> Subject: Re: svn commit: r334593 - in head/dns: bind96 bind96/files bind98 bind98/files bind99 bind99/files Message-ID: <20131126083958.GG19582@ithaqua.etoilebsd.net> In-Reply-To: <20131126075122.GA88351@FreeBSD.org> References: <201311221341.rAMDfY3g002148@svn.freebsd.org> <01490d316b5dd7f01f1c843871542666@secure.marino.st> <2DEEB271-4795-4DF0-8F85-30316BA3070F@FreeBSD.org> <5291C8BD.3070109@marino.st> <20131126035339.GA43389@FreeBSD.org> <20131126073851.GE19582@ithaqua.etoilebsd.net> <20131126075122.GA88351@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Fnm8lRGFTVS/3GuM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Nov 26, 2013 at 07:51:22AM +0000, Alexey Dokuchaev wrote:
> On Tue, Nov 26, 2013 at 08:38:52AM +0100, Baptiste Daroussin wrote:
> > On Tue, Nov 26, 2013 at 03:53:39AM +0000, Alexey Dokuchaev wrote:
> > > Given that OSVERSION is used extensively in the tree, I'm worrying th=
at
> > > adding these extra "${OPSYS} =3D=3D FreeBSD" checks will our makefile=
s less
> > > readable. Wouldn't it make more sense to place this check somewhere =
in
> > > single place, and define whatever OSVERSION that looks reasonable when
> > > OPSYS =3D=3D FreeBSD instead of patching every port?
> >=20
> > except that lots/most of the osversion checking in the ports tree is al=
so
> > wrong and was due to a design bug of pointyhat/tinderbox, pointyhat is =
gone,
> > and tinderbox had been fixed. there is no need anymore for most of them
> > which also are often wrong given the flexibility we have with buildworl=
d.
> >=20
> > I do plan to remove most of the useless osversion.
>=20
> Yup, I remember this was discussed on IRC a few times. I'm only looking
> forward to it. However, introducing "${OPSYS} =3D=3D FreeBSD" checks in,=
uhm,
> *FreeBSD* ports collection looks bogus to me. If <whatever>BSD wants to
> make use of it, fine, but please let's keep their little hacks outside of
> FreeBSD ports. :)
>=20
> ./danfe
We need to be friendly with other OS if they want to use the ports tree like
Dragonfly does. and I disagree to let their little hacks outside of the por=
ts
tree.
Their little hacks often shows a deficiency of the port system! for example=
the
little hack dragonfly had about config.guess/config.sub showed me that we h=
ave
never upstream our patches to it and we were using a really really old vers=
ion,
this is one of the reason why most of the autotooled software does not beha=
ve
the same when built inside and outside of the ports tree.
Tricky no? but instead of fixing and upstreaming we have prefered yelling at
autotools. (We right know have the same kind of problems with libtool)
Their "little hacks" revealed a lot, let allow them to bring it into the
"FreeBSD" ports tree!
OSVERSION means nothing outside of OSTYPE, and btw OSVERSION is also killin=
g the
dozens of vendor that keep an old version of freebsd but backporting new th=
ings
into it! or using a newer version of freebsd but lying on the version to pl=
ease
the management, or version using "vanilla" freebsd but naming it another na=
me or
another version.
Last thing is their "little hacks" allows me to discover lots of
defficiencies about our toolchain and friends, in particular how we handle =
it
inside the ports tree, this has driven me to the right direction (I hope :)=
) to
allow cross building. and OSVERSION is killing me with cross building btw :)
My 2cts on the subject.
regards,
Bapt
--Fnm8lRGFTVS/3GuM
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlKUXl4ACgkQ8kTtMUmk6EwtmACfcsfX1ctIiuiAnML9NYk8t46N
f/cAn2umDmP9QqFnb3VeLGG+0o1VCL89
=Bc2Y
-----END PGP SIGNATURE-----
--Fnm8lRGFTVS/3GuM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131126083958.GG19582>