Date: Wed, 20 Nov 2019 23:42:08 +0000 From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: "John Baldwin" <jhb@FreeBSD.org> Cc: "Warner Losh" <imp@bsdimp.com>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r354900 - head/usr.sbin/jail Message-ID: <A9CE2EDE-BF95-41EA-9F21-868804E992A2@lists.zabbadoz.net> In-Reply-To: <991bdc33-516d-6e6d-1880-44930441893d@FreeBSD.org> References: <201911201654.xAKGsMTv094014@repo.freebsd.org> <CANCZdfqVLZUqGiCDagwkULH7xegrZwehRsn8Ek-BJR=OVTpXGw@mail.gmail.com> <59bf120c-2f35-1a22-b6fa-a9c9bb8cfdf4@FreeBSD.org> <CANCZdfoG198Qqj90NS=NZ_%2BsMWoEPffGcJJmg25u4U97KgPfBQ@mail.gmail.com> <991bdc33-516d-6e6d-1880-44930441893d@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 Nov 2019, at 23:32, John Baldwin wrote:
Hijacking a side-thread:
PreS: I think we have way too many of these options and should just
remove 3/4 of them again or someone build a proper matrix documenting
them all and in which case to use in the developers handbook ;-)
> This one also seems dubious, but in a different way:
>
> usr.bin/Makefile:
>
> # ARM64TODO gprof does not build
> # RISCVTODO gprof does not build
> .if ${MACHINE_ARCH} != "aarch64" && ${MACHINE_CPUARCH} != "riscv"
> SUBDIR.${MK_TOOLCHAIN}+= gprof
> .endif
>
> Somewhat exacerbated by the whole aarch64 vs arm64 thing and probably
> confusion on when to use CPUARCH vs ARCH.
This particular case could actually be removed as I thought I made that
at least compile when I was working on s390x:
https://svnweb.freebsd.org/base?view=revision&revision=351329
You can however find more of these elsewhere:
../lib/libc/tests/sys/Makefile:.if ${MACHINE_CPUARCH} != "aarch64" &&
${MACHINE_CPUARCH} != "riscv"
../lib/libcompiler_rt/Makefile.inc:.if ${MACHINE_CPUARCH} == "aarch64"
|| ${MACHINE_CPUARCH} == "riscv"
../stand/libsa/Makefile:.if ${MACHINE_CPUARCH} == "aarch64" ||
${MACHINE_CPUARCH} == "riscv"
../usr.bin/Makefile:.if ${MACHINE_ARCH} != "aarch64" &&
${MACHINE_CPUARCH} != "riscv"
../usr.bin/gprof/Makefile:.if ${MACHINE_ARCH} != "aarch64" &&
${MACHINE_ARCH} != "riscv" && \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A9CE2EDE-BF95-41EA-9F21-868804E992A2>