Date: Thu, 3 Mar 2016 10:22:56 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= <jean-sebastien.pedron@dumbbell.fr>, svn-src-head@freebsd.org Subject: Re: svn commit: r296190 - head/contrib/openresolv Message-ID: <56D856D0.6010203@FreeBSD.org> In-Reply-To: <56D84C57.60101@dumbbell.fr> References: <201602291446.u1TEkdL9079747@repo.freebsd.org> <56D84C57.60101@dumbbell.fr>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/03/16 09:38, Jean-Sébastien Pédron wrote:
> Hi!
>
>> +# Strip any trailing dot from each name as a FQDN does not belong
>> +# in resolv.conf(5)
>> +# If you think otherwise, capture a DNS trace and you'll see libc
>> +# will strip it regardless.
>> +# This also solves setting up duplicate zones in our subscribers.
>> +strip_trailing_dots()
>> +{
>> + local n=
>> +
>> + for n; do
>> + printf "%s" "${n%.}"
>> + done
>> + printf "\n"
>> +}
>
> This specific change in openresolv removes all spaces separating names
> in the "search" or "domain" lines, because it doesn't print any
> whitespaces before/after stripped names.
>
> The result is:
> search domain1.tlddomain2.tlddomain3.tld
>
> It was fixed upstream:
> http://roy.marples.name/projects/openresolv/info/1e6ac67eb3c586a5
> http://roy.marples.name/projects/openresolv/ci/53416cf1b434dbc1?sbs=0
>
> However, it was not published in any release so far.
>
OK, I will bring it through the vendor area.
Thank you!
Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56D856D0.6010203>