Date: Wed, 04 Mar 2009 20:02:52 -0600 From: Robert Noland <rnoland@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r189367 - head/sys/dev/pci Message-ID: <1236218572.1384.19.camel@widget.2hip.net> In-Reply-To: <20090304.135606.1649768480.imp@bsdimp.com> References: <200903041823.n24INmcc049524@svn.freebsd.org> <20090304.135606.1649768480.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-2527ctG2K/UVgikmk7VI Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2009-03-04 at 13:56 -0700, M. Warner Losh wrote: > In message: <200903041823.n24INmcc049524@svn.freebsd.org> > Robert Noland <rnoland@freebsd.org> writes: > : Author: rnoland > : Date: Wed Mar 4 18:23:48 2009 > : New Revision: 189367 > : URL: http://svn.freebsd.org/changeset/base/189367 > :=20 > : Log: > : Extend the management of PCIM_CMD_INTxDIS. > : =20 > : We now explicitly enable INTx during bus_setup_intr() if it is needed= . > : Several of the ata drivers were managing this bit internally. This i= s > : better handled in pci and it should work for all drivers now. > : =20 > : We also mask INTx during bus_teardown_intr() by setting this bit. > : =20 > : Reviewed by: jhb > : MFC after: 3 days >=20 > Note: the INTxDIS bit is new in PCI 3.0, and has no effect on earlier > devices. This should be highlighted in the comments somewhere... It is documented in 2.3 as well, I'm not sure about previous versions of the spec though. robert. > Warner --=20 Robert Noland <rnoland@FreeBSD.org> FreeBSD --=-2527ctG2K/UVgikmk7VI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEABECAAYFAkmvMswACgkQM4TrQ4qfROM+0QCcDnmzqVPICx9Xh3/Qn5n9Vxf+ tasAn2yNgO+I2QEqayb+e7q0EuXb/79h =ukXp -----END PGP SIGNATURE----- --=-2527ctG2K/UVgikmk7VI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1236218572.1384.19.camel>