Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Sep 2006 21:01:55 GMT
From:      John-Mark Gurney <jmg@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 105615 for review
Message-ID:  <200609032101.k83L1tIQ061290@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=105615

Change 105615 by jmg@jmg_carbon-60 on 2006/09/03 21:01:05

	add a bit more debugging..

Affected files ...

.. //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.c#3 edit
.. //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.h#4 edit
.. //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-queue.c#3 edit

Differences ...

==== //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.c#3 (text+ko) ====

@@ -571,6 +571,7 @@
     u_int8_t command = 0;
     int error = ENOMEM, retries = 2;
 
+	device_printf(atadev->dev, "ata_getparam called\n");
     if (ch->devices &
 	(atadev->unit == ATA_MASTER ? ATA_ATA_MASTER : ATA_ATA_SLAVE))
 	command = ATA_ATA_IDENTIFY;
@@ -592,10 +593,12 @@
 	request->bytecount = sizeof(struct ata_params);
 	request->donecount = 0;
 	request->transfersize = DEV_BSIZE;
+	device_printf(atadev->dev, "ata_queue_request called\n");
 	ata_queue_request(request);
 	error = request->result;
 	ata_free_request(request);
     }
+	device_printf(atadev->dev, "ata_queue_request done\n");
 
     if (!error && (isprint(atadev->param.model[0]) ||
 		   isprint(atadev->param.model[1]))) {

==== //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-all.h#4 (text+ko) ====

@@ -357,7 +357,7 @@
 };
 
 /* define this for debugging request processing */
-#if 0
+#if 1
 #define ATA_DEBUG_RQ(request, string) \
     { \
     if (request->flags & ATA_R_DEBUG) \

==== //depot/projects/kmacy_sun4v_stable/src/sys/dev/ata/ata-queue.c#3 (text+ko) ====

@@ -63,6 +63,7 @@
 	    (request->callback)(request);
 	return;
     }
+	device_printf(request->dev, "in ata_queue_request\n");
     ch = device_get_softc(request->parent);
     callout_init_mtx(&request->callout, &ch->state_mtx, CALLOUT_RETURNUNLOCKED);
     if (!request->callback && !(request->flags & ATA_R_REQUEUE))



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200609032101.k83L1tIQ061290>