Date: Mon, 25 Mar 2013 16:30:00 GMT From: John Marino <draco@marino.st> To: freebsd-python@FreeBSD.org Subject: Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports Message-ID: <201303251630.r2PGU0Hf070863@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/177350; it has been noted by GNATS. From: John Marino <draco@marino.st> To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/177350: x11-toolkits/py-qt: [PATCH] fix provided from DragonFly Ports Date: Mon, 25 Mar 2013 17:26:17 +0100 From that error log, I'd say there was a mistake applying the patch. There is no "ANY" definition in the compile line which the extra cxx flags are supposed to add. Yes, this patch is to be applied after the existing patch is applied. From that, you can of course regenerate a new single patch for configure. I think there is a misunderstanding about the nature of this PR. py-qt builds on DragonFly Ports because I patched it. It came up on the mail list that somebody wanted it fixed on FreeBSD. I had the solution and I spent a couple of minutes writing a PR to let FreeBSD Ports developers know that. I never meant that these patches were a drop-in fix. I didn't have the time to generate a patch and test in on FreeBSD. I was leaving that up to the port maintainer. In any case, I'd double check the work because applying this patch on top of the existing patches *does* fix it on DragonFly and NetBSD. The error in the log looks like the error I saw before any patch was applied, so that's why I think suspect the patch in this PR wasn't accurately applied.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303251630.r2PGU0Hf070863>