Date: Sat, 18 Mar 2023 03:46:36 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Charlie Li <vishwin@freebsd.org> Cc: Konstantin Belousov <kib@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: c5c9d980c4b0 - main - libc/csu: rename ignore_init.c to libc_start1.c Message-ID: <137554A7-8067-4E77-96A8-A0B4BF813184@freebsd.org> In-Reply-To: <8d3503f3-fd05-5f1c-7470-48cef3c9bd2d@freebsd.org> References: <202303112320.32BNKoJe039514@gitrepo.freebsd.org> <8d3503f3-fd05-5f1c-7470-48cef3c9bd2d@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 Mar 2023, at 03:44, Charlie Li <vishwin@freebsd.org> wrote:
>=20
> Konstantin Belousov wrote:
>> libc/csu: rename ignore_init.c to libc_start1.c
>> The current name was a historical curiosity that started =
when init array
>> support was added, and then the file appeared a convenient place =
for the
>> addition of the MI common code to csu. It is now referenced by =
name in
>> single place and the rename is easy, so do it.
>> Sponsored by: The FreeBSD Foundation
>> MFC after: 3 weeks
>> ---
>> lib/libc/csu/Makefile.inc | 2 +-
>> lib/libc/csu/{ignore_init.c =3D> libc_start1.c} | 0
>> 2 files changed, 1 insertion(+), 1 deletion(-)
> Seems like an ABI break. Anything compiled after this but ran on an =
earlier-by-revision-but-same __FreeBSD_version complains with 'Undefined =
symbol "__libc_start1@FBSD_1.7"'
It=E2=80=99s not a break, just new ABI. Same as adding a new function, =
just
everything automatically uses it.
It=E2=80=99s true that __FreeBSD_version needs bumping if it hasn=E2=80=99=
t already
been though.
Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?137554A7-8067-4E77-96A8-A0B4BF813184>