Date: Wed, 16 Mar 2016 15:56:38 -0700 From: Conrad Meyer <cem@FreeBSD.org> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296927 - in head: share/man/man9 sys/kern sys/sys Message-ID: <CAG6CVpXtAFT77a5eftBj5bSZ4Mg9-QQEmWSa3ynHL76P=ZZT9A@mail.gmail.com> In-Reply-To: <alpine.BSF.2.00.1603162201441.92377@ai.fobar.qr> References: <201603160422.u2G4MWg1012528@repo.freebsd.org> <alpine.BSF.2.00.1603162201441.92377@ai.fobar.qr>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry. I guess that whole routine needs to be wrapped in #if defined(STACK). I'll work to put together a patch soon. Thanks, Conrad On Wed, Mar 16, 2016 at 3:02 PM, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote: > On Wed, 16 Mar 2016, Conrad E. Meyer wrote: > >> Author: cem >> Date: Wed Mar 16 04:22:32 2016 >> New Revision: 296927 >> URL: https://svnweb.freebsd.org/changeset/base/296927 >> >> Log: >> fail(9): Upstreaming some fail point enhancements >> >> This is several year's worth of fail point upgrades done at EMC Isilon. >> They >> are interdependent enough that it makes sense to put a single diff up for >> them. >> Primarily, we added: >> >> - Changing all mainline execution paths to be lockless, which lets us use >> fail >> points in more sleep-sensitive areas, and allows more parallel >> execution >> - A number of additional commands, including 'pause' that lets us do some >> interesting deterministic repros of race conditions >> - The ability to dump the stacks of all threads sleeping on a fail point >> - A number of other API changes to allow marking up the fail point's >> context in >> the code, and firing callbacks before and after execution >> - A man page update >> >> Submitted by: Matthew Bryan <matthew.bryan@isilon.com> >> Reviewed by: cem (earlier version), jhb, kib, pho >> With feedback from: bdrewery >> Sponsored by: EMC / Isilon Storage Division >> Differential Revision: https://reviews.freebsd.org/D5427 >> >> Modified: >> head/share/man/man9/fail.9 >> head/sys/kern/kern_fail.c >> head/sys/kern/subr_sleepqueue.c >> head/sys/sys/fail.h >> head/sys/sys/sleepqueue.h > > > This seems to have broken a few kernel configs (just one example); > > linking kernel.full > subr_sleepqueue.o: In function `sleepq_sbuf_print_stacks': > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x448): undefined > reference to `stack_create' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x448): > relocation truncated to fit: R_MIPS_26 against `stack_create' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x504): undefined > reference to `stack_save_td' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x504): > relocation truncated to fit: R_MIPS_26 against `stack_save_td' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x598): undefined > reference to `stack_sbuf_print' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x598): > relocation truncated to fit: R_MIPS_26 against `stack_sbuf_print' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x5f0): undefined > reference to `stack_destroy' > /scratch/tmp/bz/head.svn/sys/kern/subr_sleepqueue.c:(.text+0x5f0): > relocation truncated to fit: R_MIPS_26 against `stack_destroy' > --- kernel.full --- > *** [kernel.full] Error code 1 > > bmake[5]: stopped in > /storage/head/obj/mips.mipsn32/scratch/tmp/bz/head.svn/sys/XLPN32
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXtAFT77a5eftBj5bSZ4Mg9-QQEmWSa3ynHL76P=ZZT9A>