Date: Fri, 28 Jul 2006 19:33:51 +0200 From: Juergen Lock <qemu-l@jelal.kn-bremen.de> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: freebsd-emulation@FreeBSD.org, qemu-devel@nongnu.org, freebsd-usb@FreeBSD.org Subject: Re: FreeBSD qemu 0.8.2 update - please test! (and usb cardreader SET_ADDR_FAILED) Message-ID: <20060728173351.GA6314@saturn.kn-bremen.de> In-Reply-To: <200607251906.10687.jkim@FreeBSD.org> References: <20060723224041.GA20196@saturn.kn-bremen.de> <20060725174719.GA16116@saturn.kn-bremen.de> <200607251906.10687.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 25, 2006 at 07:06:02PM -0400, Jung-uk Kim wrote:
> On Tuesday 25 July 2006 01:47 pm, Juergen Lock wrote:
> > @@ -47,21 +43,20 @@
> > void set_float_rounding_mode(int val STATUS_PARAM)
> > {
> > STATUS(float_rounding_mode) = val;
> > --#if defined(_BSD) && !defined(__APPLE__)
> > -+#if defined(_BSD) && !defined(__APPLE__) && \
> > -+ (defined(__FreeBSD__) && __FreeBSD_version < 500000)
> > +-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
> > ++#if (defined(_BSD) && (defined(__FreeBSD__) && __FreeBSD_version < 500000)) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
> > fpsetround(val);
> > #elif defined(__arm__)
> > /* nothing to do */
>
> FYI, a parenthesis is misplaced (Note: I just rearranged
> the order to be more clearer):
>
> +-#if defined(_BSD) && !defined(__APPLE__) || (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
> ++#if (defined(_BSD) && !defined(__APPLE__) && (defined(__FreeBSD__) && __FreeBSD_version < 500000)) || \
> ++ (defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
Well this should actually be:
#if defined(_BSD) && !defined(__APPLE__) && !defined(__FreeBSD__) || \
(defined(__FreeBSD__) && __FreeBSD_version < 500000) || \
(defined(HOST_SOLARIS) && HOST_SOLARIS < 10)
if it ever was going to be merged back. (wrongly excluded non-FreeBSD BSDs)
>
> Actually it is an upstream bug, though.
Nah, the parens there are okay... (|| binds less than &&, i.e.
1 || 0 && 0 evaluates to 1.)
On another note, am i the only one seeing those -kernel-kqemu problems?
thanx,
Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060728173351.GA6314>