Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Sep 2009 08:38:25 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r196858 - head/sys/dev/rp
Message-ID:  <200909050838.n858cP6f042100@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Sat Sep  5 08:38:25 2009
New Revision: 196858
URL: http://svn.freebsd.org/changeset/base/196858

Log:
  These checks against BUSY aren't needed: the newbus layer does this
  already with the appropriate locks held...  There's no need to do it
  here, so just delete the checks.

Modified:
  head/sys/dev/rp/rp_pci.c

Modified: head/sys/dev/rp/rp_pci.c
==============================================================================
--- head/sys/dev/rp/rp_pci.c	Sat Sep  5 08:09:35 2009	(r196857)
+++ head/sys/dev/rp/rp_pci.c	Sat Sep  5 08:38:25 2009	(r196858)
@@ -225,11 +225,7 @@ rp_pcidetach(device_t dev)
 {
 	CONTROLLER_t	*ctlp;
 
-	if (device_get_state(dev) == DS_BUSY)
-		return (EBUSY);
-
 	ctlp = device_get_softc(dev);
-
 	rp_pcireleaseresource(ctlp);
 
 	return (0);
@@ -240,11 +236,7 @@ rp_pcishutdown(device_t dev)
 {
 	CONTROLLER_t	*ctlp;
 
-	if (device_get_state(dev) == DS_BUSY)
-		return (EBUSY);
-
 	ctlp = device_get_softc(dev);
-
 	rp_pcireleaseresource(ctlp);
 
 	return (0);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200909050838.n858cP6f042100>