Date: Thu, 11 Dec 2008 21:57:41 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Ed Schouten <ed@80386.nl> Cc: FreeBSD Arch <freebsd-arch@freebsd.org> Subject: Re: [Patch] strnlen(3) Message-ID: <20081211195741.GW2038@deviant.kiev.zoral.com.ua> In-Reply-To: <20081211190436.GE1176@hoeg.nl> References: <49381DD4.2000506@kasimir.com> <20081211175519.GD1176@hoeg.nl> <20081211190436.GE1176@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--UaIp6+ubhcbWp687 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 11, 2008 at 08:04:36PM +0100, Ed Schouten wrote: > Hello all, >=20 > I've attached a patch, that adds strnlen(3) to libc. It also moves > strndup(3) out of __BSD_VISIBLE. I'll see if it survives `make universe' > and commit it soonish. Any comments? strndup shall stay under __BSD_VISIBLE, and strnlen declaration shall go unto this define too. Not doing this will pollute namespace for the POSIX revisions we are (partially) trying to support. I think that style recommends to put empty statements constituting loop body on the separate line, properly indented. --UaIp6+ubhcbWp687 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklBcLQACgkQC3+MBN1Mb4hc0QCfRaQhtGxsWOHsh5Q+Dycz480E lwIAoMk09aA6jKHatnF0ugevMqOw6jK+ =hUm/ -----END PGP SIGNATURE----- --UaIp6+ubhcbWp687--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081211195741.GW2038>