Date: Wed, 20 Aug 2014 11:51:16 -0700 From: Craig Rodrigues <rodrigc@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org> Subject: Re: libvirt and rebooting of a bhyve VM Message-ID: <CAG=rPVdesa%2Bd%2BJ%2BffrqRsKwDfY25X9YRQ=kYgg-5CoJvmRe%2BVA@mail.gmail.com> In-Reply-To: <201408201115.50392.jhb@freebsd.org> References: <CAG=rPVcGFSnMcMdrNtWjUtHUc0RLXps-t9WwzokNtyHQwWDfFQ@mail.gmail.com> <201408191332.48730.jhb@freebsd.org> <CAG=rPVfi0fwUyHF_dkzKX9ejo4Na4wLSuufaqBoo0U7p7ypCZA@mail.gmail.com> <201408201115.50392.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--001a11c2696ac78693050114164b Content-Type: text/plain; charset=ISO-8859-1 On Wed, Aug 20, 2014 at 8:15 AM, John Baldwin <jhb@freebsd.org> wrote: > It probably would be good to document the return codes in the man page, but > eventually they will all go away. The long term plan is to make bhyve operate > more like other hypervisors in which case a single process invocation will > mimic a power-on to power-off cycle of a machine and you wouldn't need > vmrun.sh at all (you would just run bhyve with appropriate args / config > file). In that case, the return codes will change since it won't exit for > reboots anymore. Hi, I wasn't aware of the longer term direction of bhyve. If the return codes may change in the future, I don't know if it is a good idea to document them in the man page. However, documenting the return codes in comments in the vmrun.sh script might be OK, since it is just an example that can be changed easily. What do you think of these changes to vmrun.sh: (1) Move bhyvectl --destroy outside of the while loop. It doesn't need to run if the VM has been reset. (2) Write some comments about return code of bhyve process. -- Craig --001a11c2696ac78693050114164b Content-Type: text/plain; charset=US-ASCII; name="vmrun.sh.diff.txt" Content-Disposition: attachment; filename="vmrun.sh.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hz30jy340 LS0tIHNoYXJlL2V4YW1wbGVzL2JoeXZlL3ZtcnVuLnNoLm9yaWcJMjAxNC0wOC0yMCAxMTozODow OS43ODg3MTQ5MDUgLTA3MDAKKysrIHNoYXJlL2V4YW1wbGVzL2JoeXZlL3ZtcnVuLnNoCTIwMTQt MDgtMjAgMTE6NDM6MTQuMTU4NzA2ODIxIC0wNzAwCkBAIC0xNzMsOSArMTczLDkgQEAKIAogdmly dGlvX2Rpc2tkZXY9IiRkaXNrX2RldjAiCiAKLXdoaWxlIFsgMSBdOyBkbwotCSR7QkhZVkVDVEx9 IC0tdm09JHt2bW5hbWV9IC0tZGVzdHJveSA+IC9kZXYvbnVsbCAyPiYxCiske0JIWVZFQ1RMfSAt LXZtPSR7dm1uYW1lfSAtLWRlc3Ryb3kgPiAvZGV2L251bGwgMj4mMQogCit3aGlsZSBbIDEgXTsg ZG8KIAlmaWxlICR7dmlydGlvX2Rpc2tkZXZ9IHwgZ3JlcCAiYm9vdCBzZWN0b3IiID4gL2Rldi9u dWxsCiAJcmM9JD8KIAlpZiBbICRyYyAtbmUgMCBdOyB0aGVuCkBAIC0yMzcsNiArMjM3LDE0IEBA CiAJCS1sIGNvbTEsJHtjb25zb2xlfQkJCQkJXAogCQkke2luc3RhbGxlcl9vcHR9CQkJCQlcCiAJ CSR7dm1uYW1lfQorCSMKKwkjIGJoeXZlIHJldHVybnMgdGhlIGZvbGxvd2luZyBzdGF0dXMgY29k ZXM6CisJIyAgMCAtIFZNIGhhcyBiZWVuIHJlc2V0CisJIyAgMSAtIFZNIGhhcyBiZWVuIHBvd2Vy ZWQgb2ZmCisJIyAgMiAtIFZNIGhhcyBiZWVuIGhhbHRlZAorCSMgIDMgLSBWTSBnZW5lcmF0ZWQg YSB0cmlwbGUgZmF1bHQKKwkjICBhbGwgb3RoZXIgbm9uLXplcm8gc3RhdHVzIGNvZGVzIGFyZSBl cnJvcnMKKwkjCiAJaWYgWyAkPyAtbmUgMCBdOyB0aGVuCiAJCWJyZWFrCiAJZmkK --001a11c2696ac78693050114164b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVdesa%2Bd%2BJ%2BffrqRsKwDfY25X9YRQ=kYgg-5CoJvmRe%2BVA>