Date: Fri, 14 Apr 2017 18:15:10 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Navdeep Parhar <np@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316936 - head/sys/dev/cxgbe/iw_cxgbe Message-ID: <201704150115.v3F1FAbU009132@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201704141915.v3EJFVMX093441@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > Author: np > Date: Fri Apr 14 19:15:31 2017 > New Revision: 316936 > URL: https://svnweb.freebsd.org/changeset/base/316936 > > Log: > cxgbe/iw_cxgbe: hw supports 64K (not 32K) Protection Domains. > > MFC after: 3 days > Sponsored by: Chelsio Communications > > Modified: > head/sys/dev/cxgbe/iw_cxgbe/t4.h > > Modified: head/sys/dev/cxgbe/iw_cxgbe/t4.h > ============================================================================== > --- head/sys/dev/cxgbe/iw_cxgbe/t4.h Fri Apr 14 18:56:00 2017 (r316935) > +++ head/sys/dev/cxgbe/iw_cxgbe/t4.h Fri Apr 14 19:15:31 2017 (r316936) > @@ -61,7 +61,7 @@ > > #define T4_MAX_NUM_QP (1<<16) > #define T4_MAX_NUM_CQ (1<<15) > -#define T4_MAX_NUM_PD (1<<15) > +#define T4_MAX_NUM_PD 65536 Why the change in methods of expressing powers of 2 here? This, imho, would better match the near by code as #define T4_MAX_NUM_PD (1<<16) > #define T4_EQ_STATUS_ENTRIES (L1_CACHE_BYTES > 64 ? 2 : 1) > #define T4_MAX_EQ_SIZE (65520 - T4_EQ_STATUS_ENTRIES) > #define T4_MAX_IQ_SIZE (65520 - 1) > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704150115.v3F1FAbU009132>