Date: Thu, 21 Aug 2025 17:33:38 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Enji Cooper <ngie@freebsd.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 267f8c1f4b09 - main - crypto/openssl: make vendor imports easier/less error prone Message-ID: <DDD96B3C-6698-4FA1-9816-29DCD50745F9@gmail.com> In-Reply-To: <39A8B2D8-49D9-4303-A74A-23FB38B867CC@freebsd.org> References: <202508211705.57LH50gR095150@gitrepo.freebsd.org> <39A8B2D8-49D9-4303-A74A-23FB38B867CC@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Aug 21, 2025, at 2:07 PM, Jessica Clarke <jrtc27@freebsd.org> wrote: > > On 21 Aug 2025, at 18:05, Enji Cooper <ngie@freebsd.org> wrote: >> >> The branch main has been updated by ngie: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=267f8c1f4b09431b335d5f48d84586047471f978 >> >> commit 267f8c1f4b09431b335d5f48d84586047471f978 >> Author: Enji Cooper <ngie@FreeBSD.org> >> AuthorDate: 2025-08-01 04:03:33 +0000 >> Commit: Enji Cooper <ngie@FreeBSD.org> >> CommitDate: 2025-08-21 17:02:46 +0000 >> >> crypto/openssl: make vendor imports easier/less error prone >> >> This change adds a custom BSD makefile containing multiple high-level PHONY >> targets, similar to targets provided by the ports framework. >> >> The Makefile does the following: >> - Reruns Configure with a deterministic set of arguments to ensure that >> all appropriate features have been enabled/disabled in OpenSSL. >> - Preens the pkgconfig files to remove duplicate paths in their >> `CFLAGS` and `includedir` variables. >> - Rebuilds all ASM files to ensure that the content contained is fresh. >> - Rebuilds all manpages to ensure that the content contained in the >> manpages is fresh. >> >> Some additional work needs to be done to make the manpage regeneration >> "operation" reproducible (the date the manpages were generated is >> embedded in the files). >> >> All dynamic configuration previously captured in >> `include/openssl/configuration.h` and `include/crypto/bn_conf.h` has been >> moved to `freebsd/include/dynamic_freebsd_configuration.h` and >> `freebsd/include/crypto/bn_conf.h`, respectively. This helps >> ensure that future updates don't wipe out FreeBSD customizations to >> these files, which tune behavior on a per-target architecture basis, e.g., >> ARM vs x86, 32-bit vs 64-bit, etc. >> >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D51663 > > Something in this breaks building on macOS (where, as of recently, we > build libcrypto as a bootstrap library for use by the certctl bootstrap > tool): > > /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_sock2.c:64:9: error: call to undeclared function 'ktls_enable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > ktls_enable(sock); > ^ > /Users/runner/work/freebsd-src/freebsd-src/crypto/openssl/crypto/bio/bio_sock2.c:202:5: error: call to undeclared function 'ktls_enable'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > ktls_enable(sock); > ^ > 2 errors generated. > --- bio_sock2.o --- > *** [bio_sock2.o] Error code 1 > > Presumably you need a BOOTSTRAPPING check somewhere. It looks like the problem is MacOS doesn’t support KTLS and now KTLS has been fixed on FreeBSD. MK_OPENSSL_KTLS needs to be disabled when doing “make bootstrapping” on MacOS. Cheers, -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAminuuIACgkQGpE5DjPs NJjQeg//REkxiPADMgMx2P4IQl4y2+nk8ZNRA2oNg7dlExpP3/8U6UUiht+34+PU W7Gj9HDNDHIeNa8gFJtNG+oe9+ILkgK323bO6csspAMhMXzOuW9v6Br3KuXoZMFE jDbyR9L4Yhje5R8ZJKZhaYT6v474vRykk77CulBBr9+sSgTHGn9Qdbbp8S7fTa2D AZ1466rwmTjNut+VQut6XPj1smncP2bUZFEnwZSGvpy7G2y9zhWAVN1S7n9bzPLE T6rTXEdINbEx6DpmZnngmzz2DmNCbXPfDnOjaLVYG6I3J44H05pLFk+7djuLkiWf gtn8OP3DisGZDPhG82Ql8FeCv7Dobw+WyRipb6SQaMqV7zX5MhiBzM/Hci08Hio2 HAV5MpjHzho4bID3QQkvPT5v271txk6B+BGc7M9750gMXkz54d6LkkKzqvXEX9oM RPtemlbMbfEfjXKnnjwFVObiVfVrj4Il4BfnwehbneKFmYVeE3O3hXNbpQZcoi9n t1Q0Jkb6ZgDi/1nQFFMEYU7xjohqsJ6eRs8FoJejRzVnV/T4gAhRCchIRRtE6KK6 uZNns2gP7cE3BI4i8bp9E5FwO5NPlsf+PZAFTN5rI+whG9bHdaMeJ+jOy6UZ4OB1 tL8MMf/ZehvrRVZsz+XqKZ4lOFLM6hlieit1E7qVpZ/cBaJqVig= =xh3n -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DDD96B3C-6698-4FA1-9816-29DCD50745F9>