Date: Thu, 16 Jan 2003 23:46:25 +0200 From: Andy Fawcett <andy@athame.co.uk> To: Sean Kelly <smkelly@zombie.org>, current@freebsd.org Cc: kde@FreeBSD.org Subject: Re: x11/kdebase3 build? Message-ID: <200301162346.26059.andy@athame.co.uk> In-Reply-To: <20030116211424.GA70354@edgemaster.zombie.org> References: <20030116211424.GA70354@edgemaster.zombie.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 16 January 2003 23:14, Sean Kelly wrote:
> I'm not entirely sure this belongs on -CURRENT, but I couldn't find
> any KDE specific list similar to -gnome
kde@FreeBSD.org will get you there.
> and I seem to recall that the
> building of KDE3 was a desired goal for FreeBSD 5.0.
It is.
> That said, I
> apologize in advance if this is the wrong place to take this.
> memory_fbsd.cpp:33: `VM_METER' undeclared (first use this function)
As separately explained by Bruce, this has been changed on -current as a
result of an old old PR.
To be honest, replacing the old #define would seem to be too drastic a
fix, bearing in mind that there's probably quite a few pieces of
software out there that use it.
How about:
#define VM_TOTAL 1 /* struct vmtotal */
/* The following define is deprecated in favour of the above one
and should not be used in new code */
#define VM_METER 1 /* struct vmmeter */
This would make code build on FreeBSD versions with either definition,
without having to have horrible workarounds to work on them both. Or
worse, programmers stopping using the name and just using the value 1
instead, which would be easy and very nasty to follow.
As it is at the moment, I can see something like:
#ifndef VM_METER
#define VM_METER VM_TOTAL
#endif
springing up all over the place...
Regards,
Andy
--
Andy Fawcett | andy@athame.co.uk
| tap@kde.org
"In an open world without walls and fences, | tap@lspace.org
we wouldn't need Windows and Gates." -- anon | tap@fruitsalad.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200301162346.26059.andy>