Date: Thu, 10 Oct 2024 14:25:43 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2851aafe96c1 - main - mlx5 ipsec_offload: ensure that driver does not dereference dead sahindex Message-ID: <9DD418B6-E346-4ED8-9212-6BD555FB2431@FreeBSD.org> In-Reply-To: <202410101000.49AA07wh039872@gitrepo.freebsd.org> References: <202410101000.49AA07wh039872@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 10 Oct 2024, at 12:00, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2851aafe96c1e357971f2b331fff837ead20522b > > commit 2851aafe96c1e357971f2b331fff837ead20522b > Author: Konstantin Belousov <kib@FreeBSD.org> > AuthorDate: 2024-09-28 23:17:05 +0000 > Commit: Konstantin Belousov <kib@FreeBSD.org> > CommitDate: 2024-10-10 09:55:45 +0000 > > mlx5 ipsec_offload: ensure that driver does not dereference dead > sahindex > > Take the sahtree rlock and check for the DEAD SA state before > validating > and filling the SA xfrm attributes. > > Sponsored by: NVidia networking > --- I believe this commit breaks LINT-NOIP builds: --- kernel --- linking kernel ld: error: undefined symbol: ipsec_sahtree_rlock >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) ld: error: undefined symbol: ipsec_sahtree_runlock >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) *** [kernel] Error code 1 Best regards, Kristof [-- Attachment #2 --] <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/xhtml; charset=utf-8"> </head> <body><div style="font-family: sans-serif;"><div class="markdown" style="white-space: normal;"> <p dir="auto">On 10 Oct 2024, at 12:00, Konstantin Belousov wrote:</p> </div><div class="plaintext" style="white-space: normal;"><blockquote style="margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136BCE; color: #136BCE;"><p dir="auto">The branch main has been updated by kib:</p> <p dir="auto">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=2851aafe96c1e357971f2b331fff837ead20522b">https://cgit.FreeBSD.org/src/commit/?id=2851aafe96c1e357971f2b331fff837ead20522b</a></p>; <p dir="auto">commit 2851aafe96c1e357971f2b331fff837ead20522b <br> Author: Konstantin Belousov <kib@FreeBSD.org> <br> AuthorDate: 2024-09-28 23:17:05 +0000 <br> Commit: Konstantin Belousov <kib@FreeBSD.org> <br> CommitDate: 2024-10-10 09:55:45 +0000</p> <p dir="auto"> mlx5 ipsec_offload: ensure that driver does not dereference dead sahindex</p> <p dir="auto"> Take the sahtree rlock and check for the DEAD SA state before validating <br> and filling the SA xfrm attributes.</p> <p dir="auto"> Sponsored by: NVidia networking <br> ---</p> </blockquote></div> <div class="markdown" style="white-space: normal;"> <p dir="auto">I believe this commit breaks LINT-NOIP builds:</p> <pre style="margin-left: 15px; margin-right: 15px; padding: 5px; border: thin solid gray; overflow-x: auto; max-width: 90vw; background-color: #E4E4E4;"><code style="padding: 0 0.25em; background-color: #E4E4E4;">--- kernel --- linking kernel ld: error: undefined symbol: ipsec_sahtree_rlock >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) ld: error: undefined symbol: ipsec_sahtree_runlock >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) >>> referenced by mlx5_ipsec.c >>> mlx5_ipsec.o:(mlx5e_if_sa_newkey_onedir) *** [kernel] Error code 1 </code></pre> <p dir="auto">Best regards,<br> Kristof</p> </div> </div> </body> </html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9DD418B6-E346-4ED8-9212-6BD555FB2431>