Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 28 Dec 2017 05:34:29 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r327277 - head/usr.bin/wall
Message-ID:  <201712280534.vBS5YTcr024847@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Thu Dec 28 05:34:29 2017
New Revision: 327277
URL: https://svnweb.freebsd.org/changeset/base/327277

Log:
  Close the fp rather than the fd since we fdopen the fd so we don't
  leak the FILE *.
  
  CID: 978383

Modified:
  head/usr.bin/wall/wall.c

Modified: head/usr.bin/wall/wall.c
==============================================================================
--- head/usr.bin/wall/wall.c	Thu Dec 28 05:34:24 2017	(r327276)
+++ head/usr.bin/wall/wall.c	Thu Dec 28 05:34:29 2017	(r327277)
@@ -290,5 +290,5 @@ makemsg(char *fname)
 		err(1, "out of memory");
 	if ((int)fread(mbuf, sizeof(*mbuf), mbufsize, fp) != mbufsize)
 		err(1, "can't read temporary file");
-	(void)close(fd);
+	fclose(fp);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712280534.vBS5YTcr024847>