Date: Tue, 19 Oct 2010 20:38:21 +0000 (UTC) From: Jung-uk Kim <jkim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r214076 - head/sys/dev/acpica Message-ID: <201010192038.o9JKcLah026293@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jkim Date: Tue Oct 19 20:38:21 2010 New Revision: 214076 URL: http://svn.freebsd.org/changeset/base/214076 Log: Remove undocumented and stale debug.acpi.do_powerstate tunable. It was added with hw.pci.do_powerstate but the PCI version was splitted into two separate tunables later and now this is completely stale. To make it worse, PCI devices enumerated in ACPI tree ignore this tunable as it is handled by a function in acpi_pci.c instead. Modified: head/sys/dev/acpica/acpi.c Modified: head/sys/dev/acpica/acpi.c ============================================================================== --- head/sys/dev/acpica/acpi.c Tue Oct 19 20:17:17 2010 (r214075) +++ head/sys/dev/acpica/acpi.c Tue Oct 19 20:38:21 2010 (r214076) @@ -254,12 +254,6 @@ TUNABLE_INT("debug.acpi.interpreter_slac SYSCTL_INT(_debug_acpi, OID_AUTO, interpreter_slack, CTLFLAG_RDTUN, &acpi_interpreter_slack, 1, "Turn on interpreter slack mode."); -/* Power devices off and on in suspend and resume. XXX Remove once tested. */ -static int acpi_do_powerstate = 1; -TUNABLE_INT("debug.acpi.do_powerstate", &acpi_do_powerstate); -SYSCTL_INT(_debug_acpi, OID_AUTO, do_powerstate, CTLFLAG_RW, - &acpi_do_powerstate, 1, "Turn off devices when suspending."); - /* Reset system clock while resuming. XXX Remove once tested. */ static int acpi_reset_clock = 1; TUNABLE_INT("debug.acpi.reset_clock", &acpi_reset_clock); @@ -668,9 +662,6 @@ acpi_set_power_children(device_t dev, in struct pci_devinfo *dinfo; int dstate, i, numdevs; - if (!acpi_do_powerstate) - return; - if (device_get_children(dev, &devlist, &numdevs) != 0) return; @@ -1493,9 +1484,6 @@ acpi_set_powerstate(device_t child, int ACPI_HANDLE h; ACPI_STATUS status; - if (!acpi_do_powerstate) - return (0); - h = acpi_get_handle(child); if (state < ACPI_STATE_D0 || state > ACPI_D_STATES_MAX) return (EINVAL);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010192038.o9JKcLah026293>