Date: Sun, 24 Sep 1995 13:37:22 -0400 (EDT) From: John Capo <jc@irbs.com> To: phk@critter.tfs.com (Poul-Henning Kamp) Cc: wpaul@freebsd.org, CVS-commiters@freebsd.org, cvs-gnu@freebsd.org Subject: Re: cvs commit: src/gnu/usr.sbin/ypserv server.c Message-ID: <199509241737.NAA03705@irbs.irbs.com> In-Reply-To: <170.811963760@critter.tfs.com> from "Poul-Henning Kamp" at Sep 24, 95 10:29:20 am
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp writes: > > > wpaul 95/09/24 10:21:53 > > > > Modified: gnu/usr.sbin/ypserv server.c > > Log: > > phkmalloc strikes! > > > > [...] > > > > Note that with the original malloc(), there were never any errors > > flagged. phkmalloc complained quite loudly. > > Hmm, what was the exact complaint ? that something got freed twice ? > > It is not a big deal to ignore this in phkmalloc, but I though it was > a bad idea to let it slip. > There are a bunch of bogus frees in ypserv. I linked it with gnumalloc a few months back and discovered that ypserv is freeing the result of db calls. The pointers returned point within db objects. phkmalloc cores in this case. I believe I filed a GNATS report when I first discovered this months ago. I know I posted it to -current. There are other cases where ypserv frees already freed memory. The phkmalloc warnings are a Good Thing(tm). John Capo IRBS Engineering
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509241737.NAA03705>