Date: Tue, 2 May 2023 07:38:15 -0800 From: Rob Wing <rob.fx907@gmail.com> To: Vitaliy Gusev <gusev.vitaliy@gmail.com> Cc: =?UTF-8?Q?Corvin_K=C3=B6hne?= <corvink@freebsd.org>, Matthew Grooms <mgrooms@shrew.net>, freebsd-hackers@freebsd.org, freebsd-virtualization@freebsd.org, Elena Mihailescu <elenamihailescu22@gmail.com>, Mihai Carabas <mihai.carabas@gmail.com> Subject: Re: BHYVE_SNAPSHOT Message-ID: <CAF3%2Bn_eAzZiT%2Bu3-P9EJu37ZSGzwmMyQn7YMhoF3ptTOenJW=g@mail.gmail.com> In-Reply-To: <ACFE251D-F4ED-4901-A692-618DC64E9B0E@gmail.com> References: <ZEz8tU_83QfqbbMu@int21h> <fe221c6a-acb7-ddbd-413d-7039de33e872@shrew.net> <CAF3%2Bn_fN4J4jXH89t8gMOD8QpqAike0Uzrb9wUfKoYv56zQt_w@mail.gmail.com> <89c84bd7-a925-02f4-acbe-12c3000e7007@shrew.net> <3ab4e6d94fb0153fb6ff4a53ac6f53b2eaae0cf7.camel@FreeBSD.org> <ACFE251D-F4ED-4901-A692-618DC64E9B0E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, May 2, 2023 at 3:00 AM Vitaliy Gusev <gusev.vitaliy@gmail.com> wrote: > Just add some plans for me: > > 1. Describe snapshot file format: One file for snapshot. > > 2. Implement snapshot/resume via nvlist. > > *nvlist* implementation brings: > > > - Versioning > - Easy debugging, getting saved values, etc. > - Validate restored variables: types, sized, etc. > - Add optional variables without breaking backward compatibility > (resume can be performed with old snapshots) > - Remove variables without breaking backward compatibility > - Use one file for snapshot > - Improve restore command line: "bhyve -r $snapshot”, i.e. w/o > additional arguments > > Do you plan on saving the guest memory into the nvlist? If I have VM with 8 gigs of memory, will the nvlist implementation allocate 8 gigs of memory for the nvlist then write it out to disk? Or..? All the bullet points look good to me. -Rob [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 2, 2023 at 3:00 AM Vitaliy Gusev <<a href="mailto:gusev.vitaliy@gmail.com">gusev.vitaliy@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>Just add some plans for me:<div><br></div><div> 1. Describe snapshot file format: One file for snapshot.</div><div><br></div><div> 2. Implement snapshot/resume via nvlist.</div><div><br></div><div> <b>nvlist</b> implementation brings:</div><div><br></div><div><ul><li>Versioning</li><li>Easy debugging, getting saved values, etc.</li><li>Validate restored variables: types, sized, etc.</li><li>Add optional variables without breaking backward compatibility (resume can be performed with old snapshots)</li><li>Remove variables without breaking backward compatibility</li><li>Use one file for snapshot</li><li>Improve restore command line: "bhyve -r $snapshot”, i.e. w/o additional arguments</li></ul></div></div></blockquote><div><br></div><div>Do you plan on saving the guest memory into the nvlist? If I have VM with 8 gigs of memory, will the nvlist implementation allocate 8 gigs of memory for the nvlist then write it out to disk? Or..?</div><div><br></div><div>All the bullet points look good to me.</div><div><br></div><div>-Rob<br></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF3%2Bn_eAzZiT%2Bu3-P9EJu37ZSGzwmMyQn7YMhoF3ptTOenJW=g>