Date: Wed, 27 Oct 2004 19:02:23 +0000 (UTC) From: Bruce M Simpson <bms@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/pci if_vr.c Message-ID: <200410271902.i9RJ2Nui009028@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
bms 2004-10-27 19:02:23 UTC
FreeBSD src repository
Modified files:
sys/pci if_vr.c
Log:
Forcibly disable interrupts, if we find ourselves servicing one when
the device is suspended or shutting down. This will need to be rethought
slightly if we implement suspend/resume support within vr(4).
This appears to fix the vr_shutdown() panic on SMP machines.
My theory here is there's a race somewhere during vr_detach() with
vr_intr() in the SMP case which was sometimes being triggered,
although quite why this was happening is unclear (vr_stop() also
explicitly disables interrupts by writing to the IMR register).
MFC-to-RELENG_5* candidate.
PR: kern/62889
Tested by: seb at struchtrup dot com
MFC after: 10 days
Revision Changes Path
1.99 +8 -1 src/sys/pci/if_vr.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200410271902.i9RJ2Nui009028>