Date: Wed, 3 Jun 2015 16:10:35 -0700 From: Devin Teske <dteske@FreeBSD.org> To: John-Mark Gurney <jmg@funkthat.com> Cc: Ed Maste <emaste@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Devin Teske <dteske@FreeBSD.org> Subject: Re: svn commit: r283929 - head/games/grdc Message-ID: <65EE2E83-06C1-446B-94F7-6CFAB99B990D@FreeBSD.org> In-Reply-To: <20150603212651.GL50817@funkthat.com> References: <201506022053.t52KrIuk046680@svn.freebsd.org> <20150603194825.GJ50817@funkthat.com> <4D6EF798-B894-41AC-8889-84791D925D7E@FreeBSD.org> <20150603212651.GL50817@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 3, 2015, at 2:26 PM, John-Mark Gurney <jmg@funkthat.com> wrote: > > Devin Teske wrote this message on Wed, Jun 03, 2015 at 13:45 -0700: >>> On Jun 3, 2015, at 12:48 PM, John-Mark Gurney <jmg@funkthat.com> wrote: >>> >>> Ed Maste wrote this message on Tue, Jun 02, 2015 at 20:53 +0000: >>>> Author: emaste >>>> Date: Tue Jun 2 20:53:17 2015 >>>> New Revision: 283929 >>>> URL: https://svnweb.freebsd.org/changeset/base/283929 >>>> >>>> Log: >>>> Correct grdc(1) 12-hour display between 12:00 and 13:00 >>>> >>>> PM starts at 12:00, not 13:00. >>>> >>>> PR: 194291, 200133 >>>> Submitted by: Nick Price >>>> MFC after: 1 week >>> >>> The fact that this was missed for a 20+ year old program shows that >>> we should just remove it??? >> >> FYI removal was discussed on src-commmitters@ (svn-src-all@ and >> svn-src-head@ were also CC???d) on these days by these people: > > Ok, and what does this mean to you? > > To me that the two people who voiced their support of keeping it > didn't notice such a trivial bug, or bother to commit the bugs in > the database shows they aren't interested in maintaining it.. > Means that the people using it (incl. me) never hit those edge-cases. Seldom is there time to go poking around the code of things that appear to be working as-expected 100% of the time. That’s all. In the case of this particular bug, I hadn’t noticed it. And I use grdc all the time. What can we say? code gets better over time with more eyeballs (and sometimes the old eyeballs stop scrutinizing, so it’s often good to also have young eyeballs take a look at things). I don’t think this situation is a call for deprecating anything. — Devin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?65EE2E83-06C1-446B-94F7-6CFAB99B990D>