Date: Wed, 22 May 2024 13:13:15 +0200 From: Mariusz Zaborski <oshogbo@freebsd.org> To: Dmitry Salychev <dsl@freebsd.org> Cc: Lexi Winter <lexi@le-fay.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 408957613bc0 - main - Regen Message-ID: <CAGOYWV8SUDtSisWiyYqO=8N4_eyJ-Gr=Wj8_BdFcjHHwj3hu3w@mail.gmail.com> In-Reply-To: <86r0dugmik.fsf@peasant.tower.home> References: <202405212004.44LK4cBG042804@gitrepo.freebsd.org> <Zk2lBymRapenk_V8@ilythia.eden.le-fay.org> <86r0dugmik.fsf@peasant.tower.home>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000000fe260619090601 Content-Type: text/plain; charset="UTF-8" Hello, Not really as a mistake :) The files in question have many such commits (not only committed by me). So I have assumed this is a common practice. I'm happy to provide more details next time. However, I don't plan to revert it at this point as it seems pointless to complicate the log even more. For freebsd32: e90259af59a1 regen 38bfddf597b1 regen 7893419d492c Remove never implemented sbrk and sstk syscalls 30cdbb5833f6 freebsd32: Remove mac_syscall from the unimpl list af93fea71038 timerfd: Move implementation from linux compat to sys/kern c7df87209634 Regen 9121945d7003 Regenerate sysent stuff after $FreeBSD$ removal 7b42f338d7a3 freebsd32: Regen 11cdffc60325 Regen 6a0a634590e4 Regen f99cc5a38947 sysent: regen after 52a1d90c8bfe, posix_fadvise in capmode 8601fca7895c sysent: regen for syscallarg_t 0910a41ef3b9 Revert "syscallarg_t: Add a type for system call arguments" 3889fb8af0b6 sysent: regen for syscallarg_t b7c55487ff2f Regen 5c1835b1d4b5 syscalls: regen 7fb006e7d61e syscalls: regen c2996f8ad930 syscalls: regen 30bc335a0501 freebsd32: regen 97fdcfcaf799 freebsd32: remove unnecessicary headers bcd07aaa4ebd freebsd32: regen 8460d3e9e6cb freebsd32: regen And for freebsd 408957613bc0 (HEAD -> main, origin/main, origin/HEAD) Regen 663838451ec6 syscalls: regen 38bfddf597b1 regen 7893419d492c Remove never implemented sbrk and sstk syscalls af93fea71038 timerfd: Move implementation from linux compat to sys/kern c7df87209634 Regen 9121945d7003 Regenerate sysent stuff after $FreeBSD$ removal 9abba78acc2a syscalls: regenerate 11cdffc60325 Regen 6a0a634590e4 Regen f99cc5a38947 sysent: regen after 52a1d90c8bfe, posix_fadvise in capmode 8601fca7895c sysent: regen for syscallarg_t 0910a41ef3b9 Revert "syscallarg_t: Add a type for system call arguments" 3889fb8af0b6 sysent: regen for syscallarg_t b7c55487ff2f Regen 5c1835b1d4b5 syscalls: regen 7fb006e7d61e syscalls: regen c2996f8ad930 syscalls: regen e58e9a8cbd7c syscalls: regen 439c3d95638a Regen da9fe3529b3d Regen after 0dc332bff200 273728b1257f Regen 2c9764f36b6f regen syscall files after d51198d63b63 d89c1c461ce3 Reserve gaps in syscall numbers for local use 65a524b499ae Remove documentation of unimplemented syscalls 20321e622515 Regenerate syscall files after reallocation of aio_writev/aio_readv 1868a91fac5e Regenerate syscall files after addition of aio_writev/aio_readv 9dd48b87e6ca Regen. 0c5bd5f99320 Regen after r366145. Thanks, Mariusz On Wed, 22 May 2024 at 12:37, Dmitry Salychev <dsl@freebsd.org> wrote: > > Lexi Winter <lexi@le-fay.org> writes: > > > [[PGP Signed Part:Undecided]] > > Mariusz Zaborski: > >> The branch main has been updated by oshogbo: > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c4444812c3ae276ace03697ebd > >> > >> commit 408957613bc065c4444812c3ae276ace03697ebd > >> Author: Mariusz Zaborski <oshogbo@FreeBSD.org> > >> AuthorDate: 2024-05-21 20:02:50 +0000 > >> Commit: Mariusz Zaborski <oshogbo@FreeBSD.org> > >> CommitDate: 2024-05-21 20:03:20 +0000 > >> > >> Regen > >> --- > >> sys/compat/freebsd32/freebsd32_sysent.c | 2 +- > >> sys/kern/init_sysent.c | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > > > > i'm sorry if this is considered accepted practice in FreeBSD (i'm not a > > committer) but could i please request more useful commit messages than > > "Regen" for things like this? > > > > when looking through 'git log', especially 'git log --format=oneline', > > it's really not clear what this commit actually does, meaning if i'm > > looking through the log for commits related to a problem i'm having, i > > have to examine commits like this by hand to see if they're related. > > > > it would save me (and other people, i suppose) a lot of time if the > > commit message could at least mention what it's touching, e.g. "Regen > > sys/compat/freebsd32/freebsd32_sysent.c". > > > > [[End of PGP Signed Part]] > > Looks like it slipped in by mistake. I expected it to be reverted and > re-worded. > > Regards, > Dmitry > > -- > https://wiki.freebsd.org/DmitrySalychev > --00000000000000fe260619090601 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Hello,<br><br>Not really as a mistake :) The files in ques= tion have many such commits (not only committed by me). So I have assumed t= his is a common practice.<br>I'm happy to provide more details next tim= e. However, I don't plan to revert it at this point as it seems pointle= ss to complicate the log even more.<br><br>For freebsd32:<br>e90259af59a1 r= egen<br>38bfddf597b1 regen<br>7893419d492c Remove never implemented sbrk an= d sstk syscalls<br>30cdbb5833f6 freebsd32: Remove mac_syscall from the unim= pl list<br>af93fea71038 timerfd: Move implementation from linux compat to s= ys/kern<br>c7df87209634 Regen<br>9121945d7003 Regenerate sysent stuff after= $FreeBSD$ removal<br>7b42f338d7a3 freebsd32: Regen<br>11cdffc60325 Regen<b= r>6a0a634590e4 Regen<br>f99cc5a38947 sysent: regen after 52a1d90c8bfe, posi= x_fadvise in capmode<br>8601fca7895c sysent: regen for syscallarg_t<br>0910= a41ef3b9 Revert "syscallarg_t: Add a type for system call arguments&qu= ot;<br>3889fb8af0b6 sysent: regen for syscallarg_t<br>b7c55487ff2f Regen<br= >5c1835b1d4b5 syscalls: regen<br>7fb006e7d61e syscalls: regen<br>c2996f8ad9= 30 syscalls: regen<br>30bc335a0501 freebsd32: regen<br>97fdcfcaf799 freebsd= 32: remove unnecessicary headers<br>bcd07aaa4ebd freebsd32: regen<br>8460d3= e9e6cb freebsd32: regen<br><br>And for freebsd<br>408957613bc0 (HEAD -> = main, origin/main, origin/HEAD) Regen<br>663838451ec6 syscalls: regen<br>38= bfddf597b1 regen<br>7893419d492c Remove never implemented sbrk and sstk sys= calls<br>af93fea71038 timerfd: Move implementation from linux compat to sys= /kern<br>c7df87209634 Regen<br>9121945d7003 Regenerate sysent stuff after $= FreeBSD$ removal<br>9abba78acc2a syscalls: regenerate<br>11cdffc60325 Regen= <br>6a0a634590e4 Regen<br>f99cc5a38947 sysent: regen after 52a1d90c8bfe, po= six_fadvise in capmode<br>8601fca7895c sysent: regen for syscallarg_t<br>09= 10a41ef3b9 Revert "syscallarg_t: Add a type for system call arguments&= quot;<br>3889fb8af0b6 sysent: regen for syscallarg_t<br>b7c55487ff2f Regen<= br>5c1835b1d4b5 syscalls: regen<br>7fb006e7d61e syscalls: regen<br>c2996f8a= d930 syscalls: regen<br>e58e9a8cbd7c syscalls: regen<br>439c3d95638a Regen<= br>da9fe3529b3d Regen after 0dc332bff200<br>273728b1257f Regen<br>2c9764f36= b6f regen syscall files after d51198d63b63<br>d89c1c461ce3 Reserve gaps in = syscall numbers for local use<br>65a524b499ae Remove documentation of unimp= lemented syscalls<br>20321e622515 Regenerate syscall files after reallocati= on of aio_writev/aio_readv<br>1868a91fac5e Regenerate syscall files after a= ddition of aio_writev/aio_readv<br>9dd48b87e6ca Regen.<br>0c5bd5f99320 Rege= n after r366145.<br><br>Thanks,<br>Mariusz</div><br><div class=3D"gmail_quo= te"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, 22 May 2024 at 12:37, Dmi= try Salychev <<a href=3D"mailto:dsl@freebsd.org">dsl@freebsd.org</a>>= wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px = 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> Lexi Winter <<a href=3D"mailto:lexi@le-fay.org" target=3D"_blank">lexi@l= e-fay.org</a>> writes:<br> <br> > [[PGP Signed Part:Undecided]]<br> > Mariusz Zaborski:<br> >> The branch main has been updated by oshogbo:<br> >> <br> >> URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D40895761= 3bc065c4444812c3ae276ace03697ebd" rel=3D"noreferrer" target=3D"_blank">http= s://cgit.FreeBSD.org/src/commit/?id=3D408957613bc065c4444812c3ae276ace03697= ebd</a><br> >> <br> >> commit 408957613bc065c4444812c3ae276ace03697ebd<br> >> Author:=C2=A0 =C2=A0 =C2=A0Mariusz Zaborski <oshogbo@FreeBSD.or= g><br> >> AuthorDate: 2024-05-21 20:02:50 +0000<br> >> Commit:=C2=A0 =C2=A0 =C2=A0Mariusz Zaborski <oshogbo@FreeBSD.or= g><br> >> CommitDate: 2024-05-21 20:03:20 +0000<br> >> <br> >>=C2=A0 =C2=A0 =C2=A0Regen<br> >> ---<br> >>=C2=A0 sys/compat/freebsd32/freebsd32_sysent.c | 2 +-<br> >>=C2=A0 sys/kern/init_sysent.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 | 2 +-<br> >>=C2=A0 2 files changed, 2 insertions(+), 2 deletions(-)<br> ><br> > i'm sorry if this is considered accepted practice in FreeBSD (i= 9;m not a<br> > committer) but could i please request more useful commit messages than= <br> > "Regen" for things like this?<br> ><br> > when looking through 'git log', especially 'git log --form= at=3Doneline',<br> > it's really not clear what this commit actually does, meaning if i= 'm<br> > looking through the log for commits related to a problem i'm havin= g, i<br> > have to examine commits like this by hand to see if they're relate= d.<br> ><br> > it would save me (and other people, i suppose) a lot of time if the<br= > > commit message could at least mention what it's touching, e.g. &qu= ot;Regen<br> > sys/compat/freebsd32/freebsd32_sysent.c".<br> ><br> > [[End of PGP Signed Part]]<br> <br> Looks like it slipped in by mistake. I expected it to be reverted and<br> re-worded.<br> <br> Regards,<br> Dmitry<br> <br> -- <br> <a href=3D"https://wiki.freebsd.org/DmitrySalychev" rel=3D"noreferrer" targ= et=3D"_blank">https://wiki.freebsd.org/DmitrySalychev</a><br>; </blockquote></div> --00000000000000fe260619090601--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGOYWV8SUDtSisWiyYqO=8N4_eyJ-Gr=Wj8_BdFcjHHwj3hu3w>