Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jun 2021 16:37:56 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 255870] [PATCH] rpc/rpcsec_gss: Fix a double free in rpc_gss_marshal
Message-ID:  <bug-255870-227-rD6uHWlHlN@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-255870-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-255870-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255870

--- Comment #2 from Rick Macklem <rmacklem@FreeBSD.org> ---
I think your analysis is correct.

rpc_gss_marshal() is only called by
the AUTH_MARSHALL() macros and
they are only used during encoding
(x_op =3D=3D XDR_ENCODE).
--> See all uses of AUTH_MARSHALL().

Since mem_free() is not called in
xdr_bytes() for the XDR_ENCODE case,
there is no "double free".

Also, since it is on the main "always
executed" code path, any such bug would
have been detected during testing.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-255870-227-rD6uHWlHlN>