Date: Sat, 26 Oct 2013 11:05:14 -0400 From: Sean Bruno <sean_bruno@yahoo.com> To: "freebsd-current@freebsd.org" <freebsd-current@FreeBSD.org> Subject: Re: gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses Message-ID: <1382799914.32760.3.camel@localhost> In-Reply-To: <1382709872.2451.11.camel@localhost> References: <1382327452.2610.5.camel@localhost> <1382399026.7749.3.camel@localhost> <0744E30D-89EF-4340-A7DC-968AC27F302B@FreeBSD.org> <1382663626.2498.4.camel@localhost> <3656E3A3-F76E-42F4-BCFC-8B0F49FF5DA9@FreeBSD.org> <1382665803.2498.13.camel@localhost> <14061B35-A258-4368-BECD-9934CF594AE1@FreeBSD.org> <1382709872.2451.11.camel@localhost>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, 2013-10-25 at 10:04 -0400, Sean Bruno wrote: > On Fri, 2013-10-25 at 06:38 -0400, David Chisnall wrote: > > > > > > I'm simply trying to address the warnings that appear due to clang. > > I > > > find the builds very noisy and if there's a better way to address > > this > > > issue, I'm totally open to suggestions. > > > > Well, for contrib code that isn't going to be around for much longer > > like gperf, the best thing to do is probably just stick > > -Wno-logical-op-parentheses in the CFLAGS. Alternatively, adding the > > brackets as it suggested to indicate precedence is simple. > > > > David > > Agreed. Thank you for patience in dealing with me. :-) > > I will go with my original patch that simply puts parens where they can > be picked up and leave the flow of the code alone. > > http://lists.freebsd.org/pipermail/freebsd-current/2013-October/045644.html > > sean commited at SVN r257160 sean [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iQEcBAABAgAGBQJSa9oqAAoJEBkJRdwI6BaHAd8H/RLcTaAWqBz5Fe66Uw7zp+bX zBXq0VlG8wRd6JOQWfAtTCOgi4kxkYgdnFtS99vtX8BuhkabMmUzqZm7tC9WiehJ Jf7kX39zgyf52jbmK9SZR34sKI4ido1h3Cg3EExE1xxY84dxaO1Tk7vCHMOrg+lj WWfrynEzyCS8jSgkRH8jMkUCo9pLtdcv1dxJASvnsmyZCmDb3K2vWaRsiGeBdF7n ZDD43m0NEbcBkLFgoc+3qn2YfoWoK/x6VWTqkq2tssCI7cmesLQW3FlVVjGk3uv8 3MSyqfxhiqmvL5YPBUiM1GD6b11vsBNDCR0RYXLj5QEkMb+Q09oxdZmm5dRuqPQ= =8KQW -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1382799914.32760.3.camel>