Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Aug 2016 14:25:17 -0700
From:      Ngie Cooper <yaneurabeya@gmail.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r304011 - head/libexec/rtld-elf
Message-ID:  <CAGHfRMBgm3L_tZc1B5pR95-yfBigSYU8O4kgUdP6rizttCERbg@mail.gmail.com>
In-Reply-To: <20160812183636.GP83214@kib.kiev.ua>
References:  <201608121829.u7CITCIu059447@repo.freebsd.org> <35B0B56E-A536-4A07-B397-7E5ABAB4CB34@gmail.com> <20160812183636.GP83214@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 12, 2016 at 11:36 AM, Konstantin Belousov
<kostikbel@gmail.com> wrote:

...

> Because the API is unusable.  It causes full queue iteration when the object
> is NULL, i.e. at the end of the queue, instead of doing nothing.

    It would have been nice if this had been documented in the commit
message instead of leaving the reader to guess..
Thank you for the explanation -- I really appreciate it!
-Ngie



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMBgm3L_tZc1B5pR95-yfBigSYU8O4kgUdP6rizttCERbg>