Date: Tue, 14 Apr 2026 15:42:03 -0400 From: John Baldwin <jhb@FreeBSD.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4fadf2466468 - main - tcp_close: Use in6_pcbdisconnect for INET6 sockets Message-ID: <1fcc8e29-5a8c-4596-91d9-8212ff8cc379@FreeBSD.org> In-Reply-To: <ad6WC94osTHMGc5Y@cell.glebi.us> References: <69de895e.398d0.7253ff8b@gitrepo.freebsd.org> <ad6WC94osTHMGc5Y@cell.glebi.us>
index | next in thread | previous in thread | raw e-mail
On 4/14/26 15:31, Gleb Smirnoff wrote: > On Tue, Apr 14, 2026 at 06:37:18PM +0000, John Baldwin wrote: > J> The branch main has been updated by jhb: > J> > J> URL: https://cgit.FreeBSD.org/src/commit/?id=4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 > J> > J> commit 4fadf2466468dd6dcb6cf9e3739ed696a18c1bb4 > J> Author: John Baldwin <jhb@FreeBSD.org> > J> AuthorDate: 2026-04-14 18:07:51 +0000 > J> Commit: John Baldwin <jhb@FreeBSD.org> > J> CommitDate: 2026-04-14 18:07:51 +0000 > J> > J> tcp_close: Use in6_pcbdisconnect for INET6 sockets > J> > J> This also fixes the LINT-NOINET builds. > J> > J> Fixes: 40dbb06fa73c ("inpcb: retire INP_DROPPED and in_pcbdrop()") > > Thanks! I wonder how did it pass the tests. Looks like we don't have > any UDPv6 tests? If you look at in_pcbdisconnect and in6_pcbdisconnect they are mostly the same and given that it was a close operation about to discard the pcb anyway, the differences probably didn't matter in practice. I only noticed due to make tinderbox being broken. -- John Baldwinhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1fcc8e29-5a8c-4596-91d9-8212ff8cc379>