Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 17 Dec 2024 17:35:56 +0000
From:      Ruslan Bukin <br@freebsd.org>
To:        Jessica Clarke <jrtc27@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: 56816e687557 - main - riscv: Eswin hwreset support added.
Message-ID:  <Z2G2fA1iv3tVDcSE@bsdpad.com>
In-Reply-To: <F35C5308-535A-460F-9076-A1357F022C8F@freebsd.org>
References:  <202412171147.4BHBlAs7010565@gitrepo.freebsd.org> <F35C5308-535A-460F-9076-A1357F022C8F@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 17, 2024 at 02:39:00PM +0000, Jessica Clarke wrote:
> On 17 Dec 2024, at 11:47, Ruslan Bukin <br@FreeBSD.org> wrote:
> > 
> > The branch main has been updated by br:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=56816e68755725371ac89dc5aa882fdce46605a5
> > 
> > commit 56816e68755725371ac89dc5aa882fdce46605a5
> > Author:     Ruslan Bukin <br@FreeBSD.org>
> > AuthorDate: 2024-12-17 11:35:08 +0000
> > Commit:     Ruslan Bukin <br@FreeBSD.org>
> > CommitDate: 2024-12-17 11:46:10 +0000
> > 
> >    riscv: Eswin hwreset support added.
> > 
> >    Add reset controller driver for Eswin EIC7700.
> > 
> >    This one has two reset cells in FDT, which is unusual, so provide a
> >    custom hwreset_map method.
> > 
> >    Tested on SiFive Premier P550.
> > 
> >    Reviewed by: mhorne, jrtc27
> 
> I gave one review comment, I didn’t get to approving it. Are you
> writing these manually rather than using (git-)arc?...
> 
> Jess
> 

I apologize. I'm using git arc. The comment you left resulted to a
positive impact on the code so I decided to indicate you as well,
despite you did not press Accept.

Ruslan




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Z2G2fA1iv3tVDcSE>