Date: Thu, 24 Nov 2016 11:11:21 -0800 From: John Baldwin <jhb@freebsd.org> To: Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= <des@des.no> Cc: Marcelo Araujo <araujobsdport@gmail.com>, araujo@freebsd.org, src-committers@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r309109 - head/lib/libutil Message-ID: <2094160.1ufjjsmd6m@ralph.baldwin.cx> In-Reply-To: <861sy0n8re.fsf@desk.des.no> References: <201611241450.uAOEoLA5079215@repo.freebsd.org> <CAOfEmZgexP65RKz1=WxcFBWTYGYbnSHWMzknkGAeFN=DwjBL8A@mail.gmail.com> <861sy0n8re.fsf@desk.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday, November 24, 2016 05:27:17 PM Dag-Erling Smørgrav wrote:
> Marcelo Araujo <araujobsdport@gmail.com> writes:
> > We have code review, we have some many ways for communication, even
> > revert a commit if needed.
>
> No. This is the kind of mistake where the code will seem to work just
> fine and end up in a release before a user suddenly discovers that they
> have two instances of the same daemon running and trashing their data.
> If I remember correctly, the last time someone touched flopen(),
> everything worked except 'service mountd reload' stopped working.
Of course, there's only one person who has touched flopen:
% svn log -q flopen.c | awk -F \| '/^r/ { print $2 }' | sort | uniq -c
12 des
Perhaps you were just warning yourself? :)
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2094160.1ufjjsmd6m>