Date: Wed, 8 Jun 2005 12:30:47 +0200 From: Stefan Farfeleder <stefan@fafoe.narf.at> To: Michael Reifenberger <mike@Reifenberger.com> Cc: standards@freebsd.org Subject: Re: libstand functions not ansi-c compiliant Message-ID: <20050608103045.GC16848@wombat.fafoe.narf.at> In-Reply-To: <20050608094851.D29843@fw.reifenberger.com> References: <20050608094851.D29843@fw.reifenberger.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 08, 2005 at 09:53:15AM +0200, Michael Reifenberger wrote: > Hi, > as it seems are a few functions as defined/implemented in libstand > not ansi-c compiant: putchar, vprintf, vsprintf. > They are defined to return void instead of int. libstand isn't intended to be a standards-compliant C library. I'm afraid I don't see the advantages of your proposed changes. > -void > +int > vprintf(const char *fmt, va_list ap) > { > + int retval; > > kvprintf(fmt, putchar, NULL, 10, ap); retval = kvprintf(fmt, putchar, NULL, 10, ap); > + return(retval); > } > @@ -369,7 +369,7 @@ > */ > extern int getchar(void); > extern int ischar(void); > -extern void putchar(int); > +extern int putchar(int); You can't just change the return type in the header without changing all definitions of putchar(). Stefan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050608103045.GC16848>