Date: Mon, 14 Nov 2011 16:31:16 +1100 From: Peter Jeremy <peterjeremy@acm.org> To: David Chisnall <theraven@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r227474 - head/sys/amd64/include Message-ID: <20111114053116.GA91295@server.vk2pj.dyndns.org> In-Reply-To: <201111122016.pACKG7sr059722@svn.freebsd.org> References: <201111122016.pACKG7sr059722@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 2011-Nov-12 20:16:07 +0000, David Chisnall <theraven@FreeBSD.org> wrote:
> Fix SIGATOMIC_M{IN,AX} on x86-64.
Thanks for that. I have two comments:
1) Could you please wrap your log messages so that lines do not exceed
80 characters.
> /* Limits of sig_atomic_t. */
>-#define SIG_ATOMIC_MIN INT32_MIN
>-#define SIG_ATOMIC_MAX INT32_MAX
>+#define SIG_ATOMIC_MIN LONG_MIN
>+#define SIG_ATOMIC_MAX LONG_MAX
2) As far as I can see, all other defines in _stdint.h, across all
architectures, have explicit lengths, so I believe this would be
better specified as:
#define SIG_ATOMIC_MIN INT64_MIN
#define SIG_ATOMIC_MAX INT64_MAX
--
Peter Jeremy
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
iEYEARECAAYFAk7Ap6QACgkQ/opHv/APuIeRbQCfW2Y3QbNypiPI6v6jRgmbyguG
ehgAnAgE/wPsM63+QkKLT3tmatXX/ini
=/kNB
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111114053116.GA91295>