Date: Fri, 17 Jan 2014 03:50:01 GMT From: Garrett Cooper <yaneurabeya@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/185648: fmtree is unnecessarily noisy Message-ID: <201401170350.s0H3o1v8028942@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/185648; it has been noted by GNATS.
From: Garrett Cooper <yaneurabeya@gmail.com>
To: FreeBSD-gnats-submit@FreeBSD.org,
freebsd-bugs@FreeBSD.org
Cc:
Subject: Re: bin/185648: fmtree is unnecessarily noisy
Date: Thu, 16 Jan 2014 19:40:20 -0800
--Apple-Mail=_3E02B388-8DD9-411B-AFF7-1ECBB3FD872E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
Doing some code inspection, the noise is benign but not human =
friendly. This patch should make it a little more human-friendly.
Thanks,
-Garrett
--Apple-Mail=_3E02B388-8DD9-411B-AFF7-1ECBB3FD872E
Content-Disposition: attachment;
filename=0001-make-the-message-when-EEXIST-occurs-with-mkdir-2-mor.patch
Content-Type: application/octet-stream;
name="0001-make-the-message-when-EEXIST-occurs-with-mkdir-2-mor.patch"
Content-Transfer-Encoding: quoted-printable
=46rom=20a3e0cf67fab89883913fe516907ab0af7883164e=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Garrett=20Cooper=20<yanegomi@gmail.com>=0A=
Date:=20Mon,=2013=20Jan=202014=2009:48:27=20-0800=0ASubject:=20[PATCH]=20=
make=20the=20message=20when=20EEXIST=20occurs=20with=20mkdir(2)=20more=0A=
=20meaningful=0A=0A---=0A=20usr.sbin/mtree/verify.c=20|=207=20+++++--=0A=20=
1=20file=20changed,=205=20insertions(+),=202=20deletions(-)=0A=0Adiff=20=
--git=20a/usr.sbin/mtree/verify.c=20b/usr.sbin/mtree/verify.c=0Aindex=20=
b7c4fd9..f708846=20100644=0A---=20a/usr.sbin/mtree/verify.c=0A+++=20=
b/usr.sbin/mtree/verify.c=0A@@=20-218,8=20+218,11=20@@=20miss(NODE=20*p,=20=
char=20*tail)=0A=20=09=09=09}=20else=20if=20(!(p->flags=20&=20F_MODE))=0A=
=20=09=09=09=20=20=20=20(void)printf("=20(directory=20not=20created:=20=
mode=20not=20specified)");=0A=20=09=09=09else=20if=20(mkdir(path,=20=
S_IRWXU))=0A-=09=09=09=09(void)printf("=20(directory=20not=20created:=20=
%s)",=0A-=09=09=09=09=20=20=20=20strerror(errno));=0A+=09=09=09=09if=20=
(errno=20=3D=3D=20EEXIST)=0A+=09=09=09=09=09(void)printf("=20(path=20=
already=20exists)");=0A+=09=09=09=09else=0A+=09=09=09=09=09=
(void)printf("=20(directory=20not=20created:=20%s)",=0A+=09=09=09=09=09=20=
=20=20=20strerror(errno));=0A=20=09=09=09else=20{=0A=20=09=09=09=09=
create=20=3D=201;=0A=20=09=09=09=09(void)printf("=20(created)");=0A--=20=0A=
1.8.4.1=0A=0A=
--Apple-Mail=_3E02B388-8DD9-411B-AFF7-1ECBB3FD872E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401170350.s0H3o1v8028942>