Date: Sat, 3 Oct 2009 10:40:23 +1100 From: Dima Panov <Fluffy@fluffy.khv.ru> To: freebsd-ports-bugs@freebsd.org Cc: freebsd-gnats-submit@freebsd.org, Matt Tosto <datahead4@gmail.com> Subject: Re: ports/139315: [MAINTAINER] audio/liblastfm - fix build with custom PREFIX Message-ID: <200910031040.28375.Fluffy@fluffy.khv.ru> In-Reply-To: <200910021923.n92JNGb5022670@www.freebsd.org> References: <200910021923.n92JNGb5022670@www.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1432490.MpRoJcWnX6
Content-Type: multipart/mixed;
boundary="Boundary-01=_o9oxK4JZYIUiw19"
Content-Transfer-Encoding: 7bit
--Boundary-01=_o9oxK4JZYIUiw19
Content-Type: Text/Plain;
charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
On Saturday 03 October 2009 06:23:16 Matt Tosto wrote:
> >Number: 139315
>=20
> Build failed when custom PREFIX was set due to an incorrect formatting of
> the CONFIGURE_ARGS in the port Makefile. Small attached patch corrects
> this issue. I'm not entirely sure if ${PREFIX} or ${LOCALBASE} is the
> proper substitution to use in the Makefile. Confirmation of this would =
be
> appreciated.
>=20
> Patch attached with submission follows:
>=20
> diff -U3 -r ../liblastfm/Makefile /usr/ports/audio/liblastfm/Makefile
> --- ../liblastfm/Makefile 2009-10-01 10:44:58.000000000 -0500
> +++ /usr/ports/audio/liblastfm/Makefile 2009-09-08 08:45:41.000000000 -05=
00
> @@ -23,7 +23,7 @@
> QT_COMPONENTS=3D corelib xml network sql gui qtestlib \
> qmake_build moc_build rcc_build uic_build
> HAS_CONFIGURE=3D yes
> -CONFIGURE_ARGS+=3D --prefix ${LOCALBASE} --release
> +CONFIGURE_ARGS+=3D -release
> MAKE_JOBS_UNSAFE=3D yes
>=20
> USE_LDCONFIG=3D yes
Patch reversed, right?=20
Args order also had a side effect.
=2D-=20
Dima "Red Fox" Panov @ Home | C73E 2B72 1FFD 61BD E206 1234 A626 76ED 93E3 =
B018
Khabarovsk, Russia | 2D30 2CCB 9984 130C 6F87 BAFC FB8B A09D D539 =
8F29
KDE@FreeBSD Team | FreeBSD committer since 10.08.2009 | FreeBSD since Sept =
1995
Twitter.com:fluffy_khv | Skype:dima.panov | Jabber.org:fluffy.khv | ICQ:174=
5024
--Boundary-01=_o9oxK4JZYIUiw19
Content-Type: text/x-patch;
charset="UTF-8";
name="liblastfm.diff"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="liblastfm.diff"
Index: audio/liblastfm/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/ports/audio/liblastfm/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
=2D-- audio/liblastfm/Makefile 5 Sep 2009 12:31:33 -0000 1.5
+++ audio/liblastfm/Makefile 2 Oct 2009 23:37:28 -0000
@@ -23,7 +23,7 @@
QT_COMPONENTS=3D corelib xml network sql gui qtestlib \
qmake_build moc_build rcc_build uic_build
HAS_CONFIGURE=3D yes
=2DCONFIGURE_ARGS+=3D -release
+CONFIGURE_ARGS+=3D --release --prefix=3D${LOCALBASE}
MAKE_JOBS_UNSAFE=3D yes
=20
USE_LDCONFIG=3D yes
--Boundary-01=_o9oxK4JZYIUiw19--
--nextPart1432490.MpRoJcWnX6
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (FreeBSD)
iEYEABECAAYFAkrGj2wACgkQpiZ27ZPjsBiEGwCg4KH0/vDZb1e+yHqaL22m+j4Z
it0AnAmcNUIy//ZQz0SBFoTefHZDZl2i
=xzCl
-----END PGP SIGNATURE-----
--nextPart1432490.MpRoJcWnX6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910031040.28375.Fluffy>