Date: Sat, 28 Mar 2015 13:33:00 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Randall Stewart <rrs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys Message-ID: <233AB248-B7A0-4A45-AB1B-6807D17C98B6@FreeBSD.org> In-Reply-To: <201503281250.t2SCoOkt020297@svn.freebsd.org> References: <201503281250.t2SCoOkt020297@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
> On 28 Mar 2015, at 12:50 , Randall Stewart <rrs@FreeBSD.org> wrote: > > Author: rrs > Date: Sat Mar 28 12:50:24 2015 > New Revision: 280785 > URL: https://svnweb.freebsd.org/changeset/base/280785 > > Log: > Change the callout to supply -1 to indicate we are not changing > CPU, also add protection against invalid CPU's as well as > split c_flags and c_iflags so that if a user plays with the active > flag (the one expected to be played with by callers in MPSAFE) without > a lock, it won't adversely affect the callout system by causing a corrupt > list. This also means that all callers need to use the macros and *not* > play with the falgs directly (like netgraph used to). > > Differential Revision: htts://reviews.freebsd.org/D1894 > Reviewed by: .. timed out but looked at by jhb, imp, adrian hselasky > tested by hiren and netflix. > Sponsored by: Netflix Inc. > > Modified: > head/sys/kern/kern_timeout.c > head/sys/netgraph/atm/sscop/ng_sscop_cust.h > head/sys/netgraph/atm/uni/ng_uni_cust.h > head/sys/sys/_callout.h > head/sys/sys/callout.h I seem mips kernels starting to fail; might also be gcc kernels; can’t say yet but you should fix this anyway please: /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c: In function 'callout_callwheel_init': /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c:270: error: convert_for_assignment: incompatible type for argument 1 of 'memset' /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c: In function 'callout_reset_sbt_on': /scratch/tmp/bz/head.svn/sys/kern/kern_timeout.c:957: error: subscripted value is neither array nor pointer — Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?233AB248-B7A0-4A45-AB1B-6807D17C98B6>