Date: Fri, 28 Feb 2003 19:35:58 +0200 From: Ruslan Ermilov <ru@freebsd.org> To: "David O'Brien" <obrien@freebsd.org> Cc: Bruce Evans <bde@freebsd.org>, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/share/man/man5 Makefile style.Makefile.5 Message-ID: <20030228173558.GA63881@sunbay.com> In-Reply-To: <20030228171650.GA66554@dragon.nuxi.com> References: <200302262043.h1QKhlN4009440@repoman.freebsd.org> <20030228170548.GA60899@sunbay.com> <20030228171650.GA66554@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2003 at 09:16:50AM -0800, David O'Brien wrote: > On Fri, Feb 28, 2003 at 07:05:48PM +0200, Ruslan Ermilov wrote: > > On Wed, Feb 26, 2003 at 12:43:47PM -0800, David E. O'Brien wrote: > > > obrien 2003/02/26 12:43:47 PST > > >=20 > > > Modified files: > > > share/man/man5 Makefile=20 > > > Added files: > > > share/man/man5 style.Makefile.5=20 > > > Log: > > > FreeBSD Makefile style guide. > > > =20 > > > Approved by: TRB > > > =20 > > > Revision Changes Path > > > 1.48 +1 -1 src/share/man/man5/Makefile > > > 1.1 +178 -0 src/share/man/man5/style.Makefile.5 (new) > > >=20 > > I seem to have missed a copy for review too. A post-commit > > review, part #1, is attached. I didn't say I have a problem with the technical contents, but I'd cretainly appreciate a pre-commit review, but okay... > As I said I asked you key points. Some of the wording is almost straight > out of your emails. :-) >=20 Why then my name is not listed under the copyright? ;) > I did have it reviewed for mdoc issues, by a > committer I don't want to drag into any potential bike sheds. >=20 > > --- style.Makefile.5 26 Feb 2003 20:43:47 -0000 1.1 > > +++ style.Makefile.5 28 Feb 2003 16:50:08 -0000 > > @@ -9,9 +9,6 @@ > > .\" 2. Redistributions in binary form must reproduce the above copyrig= ht > > .\" notice, this list of conditions and the following disclaimer in= the > > .\" documentation and/or other materials provided with the distribu= tion. > > -.\" 3. Neither the name of the author nor the names of any contributors > > -.\" may be used to endorse or promote products derived from this so= ftware > > -.\" without specific prior written permission. >=20 > Uh, generally you go changing licenses. >=20 What, you insist on keeping this clause? :-) Honestly, I thought you've just copied it straight from the style.9 file. > The rest of the style changes I have no problem making as I totally go > with the wind on mdoc-style and usage. Thanks for the diff as I'm > "monkey see, monkey do" with mdoc. >=20 Lastly, let me take a moment to thank you for finally doing this. I much appreciate your work, David! Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+X539Ukv4P6juNwoRAmqzAJ9Py3mDTGP/bwSMYc/sgl/WFk5pIQCfecoc 0tO832tlnYOgExz7cGH/4eQ= =HaCg -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030228173558.GA63881>