Date: Thu, 27 Feb 2020 17:27:08 -0800 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Warner Losh <imp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358417 - head/sys/cam Message-ID: <CAJ5_RoAqP753rz3OcxWw-CSfnmGPANT-B=XahVrAGO3yZVa2KQ@mail.gmail.com> In-Reply-To: <202002280118.01S1IBRl044620@repo.freebsd.org> References: <202002280118.01S1IBRl044620@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 27, 2020 at 5:18 PM Warner Losh <imp@freebsd.org> wrote: > Author: imp > Date: Fri Feb 28 01:18:11 2020 > New Revision: 358417 > URL: https://svnweb.freebsd.org/changeset/base/358417 > > Log: > This is a FALLTHROUGH for sure. no need for xxx comment. > > Modified: > head/sys/cam/cam_xpt.c > > Modified: head/sys/cam/cam_xpt.c > > ============================================================================== > --- head/sys/cam/cam_xpt.c Fri Feb 28 01:02:01 2020 (r358416) > +++ head/sys/cam/cam_xpt.c Fri Feb 28 01:18:11 2020 (r358417) > @@ -2690,7 +2690,7 @@ xpt_action_default(union ccb *start_ccb) > case XPT_NVME_ADMIN: > /* FALLTHROUGH */ > case XPT_MMC_IO: > - /* XXX just like nmve_io? */ > + /* FALLTHROUGH */ > case XPT_RESET_DEV: > case XPT_ENG_EXEC: > case XPT_SMP_IO: > > Okay, I'll bite. Why do XPT_NVME_ADMIN and XPT_MMC_IO get "FALLTHROUGH" comments but XPT_RESET_DEV and XPT_ENG_EXEC just get listed as part of the same grouping as XPT_SMP_IO? -Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoAqP753rz3OcxWw-CSfnmGPANT-B=XahVrAGO3yZVa2KQ>