Date: Sun, 08 Aug 2010 15:39:14 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: gavin@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r211021 - head/sys/dev/usb Message-ID: <20100808.153914.769051483995699249.imp@bsdimp.com> In-Reply-To: <alpine.LNX.2.00.1008082222500.3940@ury.york.ac.uk> References: <201008071608.o77G8bNN088653@svn.freebsd.org> <20100807.204946.244264502672924047.imp@bsdimp.com> <alpine.LNX.2.00.1008082222500.3940@ury.york.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <alpine.LNX.2.00.1008082222500.3940@ury.york.ac.uk>
Gavin Atkinson <gavin@FreeBSD.org> writes:
: On Sat, 7 Aug 2010, M. Warner Losh wrote:
: > In message: <201008071608.o77G8bNN088653@svn.freebsd.org>
: > Gavin Atkinson <gavin@FreeBSD.org> writes:
: > : Author: gavin
: > : Date: Sat Aug 7 16:08:37 2010
: > : New Revision: 211021
: > : URL: http://svn.freebsd.org/changeset/base/211021
: > :
: > : Log:
: > : Sort this file a little better: the vendors are supposed to be sorted by
: > : vendor ID in the vendor section, and by symbolic name in the product
: > : section. Products are sorted by product ID. While here, get rid of a
: > : duplicate Microsoft Mouse entry, revealed by sorting.
: >
: > I thought products were sorted by the ID number, not the ID name.
:
: Yes, within a manufacturer, products should be sorted by ID. Each
: manufacturer section is sorted by the symbolic manufacturer name, though.
Within each product section, the products are sorted by numeric id,
not symbolic id. That's how it was when I was maintaining this file,
and is how pccarddevs also works.
eg:
product ALCOR SDCR_6335 0x6335 SD/MMC Card Reader
product ALCOR SDCR_6362 0x6362 SD/MMC Card Reader
product ALCOR TRANSCEND 0x6387 Transcend JetFlash Drive
product ALCOR MA_KBD_HUB 0x9213 MacAlly Kbd Hub
product ALCOR AU9814 0x9215 AU9814 Hub
product ALCOR UMCR_9361 0x9361 USB Multimedia Card Reader
product ALCOR SM_KBD 0x9410 MicroConnectors/StrongMan Keyboard
product ALCOR NEC_KBD_HUB 0x9472 NEC Kbd Hub
product ALCOR AU6390 0x6390 AU6390 USB-IDE converter
has the last one out of order only (it should be sorted 4th in this
list).
: I'm not which one of us is misunderstanding the other - do you think my
: change is somehow wrong?
I think your change misorders things, unless I'm misreading it. It
sorts based on symbolic ID rather than numeric ID.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100808.153914.769051483995699249.imp>