Date: Thu, 14 Nov 2013 16:21:04 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Jordan Hubbard <jkh@mail.turbofuzz.com> Cc: Devin Teske <dteske@freebsd.org>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, Alfred Perlstein <alfred@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com> Subject: Re: Loader forth changes for customization Message-ID: <7DD09B24-F4D7-4ED4-83E2-E9D72C157020@fisglobal.com> In-Reply-To: <86F0F59A-2DE0-42A3-9B8B-ADB1F3CA55A1@fisglobal.com> References: <5282E56F.4020307@freebsd.org> <52832003.8080406@freebsd.org> <09673101-DB54-4D25-9989-8C80D06E266B@fisglobal.com> <5283933E.30603@freebsd.org> <A0800C10-2455-477C-A2DF-FBE5A6FE6F87@mail.turbofuzz.com> <5283CBD1.9010606@freebsd.org> <86F0F59A-2DE0-42A3-9B8B-ADB1F3CA55A1@fisglobal.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--_002_7DD09B24F4D74ED483E2E9D72C157020fisglobalcom_ Content-ID: <C3035FEAA31E5042B939D97B45ABF729@fisglobal.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="Windows-1252" On Nov 13, 2013, at 4:58 PM, Teske, Devin wrote: >=20 > On Nov 13, 2013, at 10:58 AM, Alfred Perlstein wrote: >>=20 >> On 11/13/13, 10:01 AM, Jordan Hubbard wrote: >>>=20 >>> On Nov 13, 2013, at 6:57 AM, Alfred Perlstein <alfred@freebsd.org> wrot= e: >>>=20 >>>> It seems to work although I will talk to the team about making separat= e files for the set commands. >>>=20 >>> Since we=92re talking about this, there is an old maxim amongst FORTH p= rogrammers that if a single word=92s=20 >>> definition takes more than a page, it=92s just too dang long. There a= re some solid reasons for that, namely the fact that forth is already hard = enough to read as it is (and I=92m speaking as a FAN of the language) and y= ou generally need to keep the =93internal stack state=94 in your head while= writing a word since the stack contract is only at word boundaries (e.g. w= ord is defined as tacking stack parameters foo and returning stack paramete= rs bar). Keeping the definitions short and sweet really helps to aid in c= omprehension. >>>=20 >>> The definition for draw-beastie currently violates that maxim, and if y= ou guys were to refactor it as part of this work, I=92m sure future generat= ions would not object! :) >>=20 >> I'll give that a shot shortly. >>=20 >=20 Here's a patch to address that specifically... https://github.com/devinteske/freebsd/commit/c07adb2a17140d52a996ea6b8ddd94= 9b3c08be1b -or- https://github.com/devinteske/freebsd/commit/c07adb2a17140d52a996ea6b8ddd94= 9b3c08be1b.diff -or- See attached SVN patch.txt --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you. --_002_7DD09B24F4D74ED483E2E9D72C157020fisglobalcom_ Content-Type: text/plain; name="patch.txt" Content-Description: patch.txt Content-Disposition: attachment; filename="patch.txt"; size=1841; creation-date="Thu, 14 Nov 2013 16:21:04 GMT"; modification-date="Thu, 14 Nov 2013 16:21:04 GMT" Content-ID: <76936954384AA24B9D4CAE8E7FCDB0EA@fisglobal.com> Content-Transfer-Encoding: base64 SW5kZXg6IHN5cy9ib290L2ZvcnRoL2JlYXN0aWUuNHRoDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gc3lzL2Jv b3QvZm9ydGgvYmVhc3RpZS40dGgJKHJldmlzaW9uIDI1NzgyMSkNCisrKyBzeXMvYm9vdC9mb3J0 aC9iZWFzdGllLjR0aAkod29ya2luZyBjb3B5KQ0KQEAgLTIwMiw1NiArMjAyLDI2IEBAIHZhcmlh YmxlIGxvZ29ZDQogCQlkcm9wDQogCXRoZW4NCiANCi0JcyIgbG9hZGVyX2xvZ28iIGdldGVudiBk dXAgLTEgPSBpZg0KLQkJbG9nb1ggQCBsb2dvWSBADQorCXMiIGxvYWRlcl9sb2dvIiBnZXRlbnYg ZHVwIC0xIDw+IGlmDQorCQlkdXAgNSArIGFsbG9jYXRlIGlmIEVOT01FTSB0aHJvdyB0aGVuDQor CQkwIDJzd2FwIHN0cmNhdCBzIiAtbG9nbyIgc3RyY2F0DQorCQlvdmVyIC1yb3QgKCBhLWFkZHIv dSAtLSBhLWFkZHIgYS1hZGRyL3UgKQ0KKwkJc2ZpbmQgICAgICggYS1hZGRyIGEtYWRkci91IC0t IGEtYWRkciB4dCBib29sICkNCisJCXJvdCAgICAgICAoIGEtYWRkciB4dCBib29sIC0tIHh0IGJv b2wgYS1hZGRyICkNCisJCWZyZWUgICAgICAoIHh0IGJvb2wgYS1hZGRyIC0tIHh0IGJvb2wgaW9y ICkNCisJCWlmIEVGUkVFIHRocm93IHRoZW4NCisJZWxzZQ0KKwkJMCAoIGNydWZ0IC0tIGNydWZ0 IGJvb2wgKSBcIGxvYWQgdGhlIGRlZmF1bHQgYmVsb3cNCisJdGhlbg0KKwkwPSBpZg0KKwkJZHJv cCAoIGNydWZ0IC0tICkNCiAJCWxvYWRlcl9jb2xvcj8gaWYNCi0JCQlvcmItbG9nbw0KKwkJCVsn XSBvcmItbG9nbw0KIAkJZWxzZQ0KLQkJCW9yYmJ3LWxvZ28NCisJCQlbJ10gb3JiYnctbG9nbw0K IAkJdGhlbg0KLQkJZHJvcCBleGl0DQogCXRoZW4NCi0NCi0JMmR1cCBzIiBiZWFzdGllIiBjb21w YXJlLWluc2Vuc2l0aXZlIDA9IGlmDQotCQlsb2dvWCBAIGxvZ29ZIEAgYmVhc3RpZS1sb2dvDQot CQkyZHJvcCBleGl0DQotCXRoZW4NCi0JMmR1cCBzIiBiZWFzdGllYnciIGNvbXBhcmUtaW5zZW5z aXRpdmUgMD0gaWYNCi0JCWxvZ29YIEAgbG9nb1kgQCBiZWFzdGllYnctbG9nbw0KLQkJMmRyb3Ag ZXhpdA0KLQl0aGVuDQotCTJkdXAgcyIgZmJzZGJ3IiBjb21wYXJlLWluc2Vuc2l0aXZlIDA9IGlm DQotCQlsb2dvWCBAIGxvZ29ZIEAgZmJzZGJ3LWxvZ28NCi0JCTJkcm9wIGV4aXQNCi0JdGhlbg0K LQkyZHVwIHMiIG9yYiIgY29tcGFyZS1pbnNlbnNpdGl2ZSAwPSBpZg0KLQkJbG9nb1ggQCBsb2dv WSBAIG9yYi1sb2dvDQotCQkyZHJvcCBleGl0DQotCXRoZW4NCi0JMmR1cCBzIiBvcmJidyIgY29t cGFyZS1pbnNlbnNpdGl2ZSAwPSBpZg0KLQkJbG9nb1ggQCBsb2dvWSBAIG9yYmJ3LWxvZ28NCi0J CTJkcm9wIGV4aXQNCi0JdGhlbg0KLQkyZHVwIHMiIHRyaWJ1dGUiIGNvbXBhcmUtaW5zZW5zaXRp dmUgMD0gaWYNCi0JCWxvZ29YIEAgbG9nb1kgQA0KLQkJcyIgdHJpYnV0ZS1sb2dvIiBzZmluZCBp Zg0KLQkJCWV4ZWN1dGUNCi0JCWVsc2UNCi0JCQlkcm9wIG9yYi1sb2dvDQotCQl0aGVuDQotCQky ZHJvcCBleGl0DQotCXRoZW4NCi0JMmR1cCBzIiB0cmlidXRlYnciIGNvbXBhcmUtaW5zZW5zaXRp dmUgMD0gaWYNCi0JCWxvZ29YIEAgbG9nb1kgQA0KLQkJcyIgdHJpYnV0ZWJ3LWxvZ28iIHNmaW5k IGlmDQotCQkJZXhlY3V0ZQ0KLQkJZWxzZQ0KLQkJCWRyb3Agb3JiYnctbG9nbw0KLQkJdGhlbg0K LQkJMmRyb3AgZXhpdA0KLQl0aGVuDQotDQotCTJkcm9wDQorCWxvZ29YIEAgbG9nb1kgQCByb3Qg ZXhlY3V0ZQ0KIDsNCiANCiA6IGNsZWFyLWJlYXN0aWUgKCAtLSApIFwgY2xlYXJzIGJlYXN0aWUg ZnJvbSB0aGUgc2NyZWVuDQo= --_002_7DD09B24F4D74ED483E2E9D72C157020fisglobalcom_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7DD09B24-F4D7-4ED4-83E2-E9D72C157020>