Date: Sun, 8 Jul 2018 09:10:27 -0600 From: Sean Bruno <sbruno@freebsd.org> To: Mark Johnston <markj@freebsd.org>, Andrew Turner <andrew@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334880 - head/sys/dev/vnic Message-ID: <ef680451-5750-e0cd-27b5-852fc8e74eb8@freebsd.org> In-Reply-To: <20180707174351.GA95934@pesky> References: <201806091447.w59ElnpU026396@repo.freebsd.org> <20180707174351.GA95934@pesky>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GvQmRhFURa83tvIVOlxHjsgU37ym3N6yw Content-Type: multipart/mixed; boundary="g7z02vWL7XFIzbuyfh2VKta7p2q26nzWV"; protected-headers="v1" From: Sean Bruno <sbruno@freebsd.org> To: Mark Johnston <markj@freebsd.org>, Andrew Turner <andrew@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <ef680451-5750-e0cd-27b5-852fc8e74eb8@freebsd.org> Subject: Re: svn commit: r334880 - head/sys/dev/vnic References: <201806091447.w59ElnpU026396@repo.freebsd.org> <20180707174351.GA95934@pesky> In-Reply-To: <20180707174351.GA95934@pesky> --g7z02vWL7XFIzbuyfh2VKta7p2q26nzWV Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 07/07/18 11:43, Mark Johnston wrote: > On Sat, Jun 09, 2018 at 02:47:49PM +0000, Andrew Turner wrote: >> Author: andrew >> Date: Sat Jun 9 14:47:49 2018 >> New Revision: 334880 >> URL: https://svnweb.freebsd.org/changeset/base/334880 >> >> Log: >> In the ThunderX BGX network driver we were skipping the NULL termina= tor >> when parsing the phy type, however this is included in the length re= turned >> by OF_getprop. To fix this stop ignoring the terminator. >> =20 >> PR: 228828 >> Reported by: sbruno >> Sponsored by: DARPA, AFRL >=20 > This seems to break vnic on packet.net ThunderXs. In particular, VF > creation fails. It seems the problem in my case is that there are > multiple PHY devices in the device tree, e.g., xfi@0, xfi@1. With this= > change, bgx_fdt_phy_name_match() fails to match against any device > containing a unit address in the node name. >=20 Huh ... this was *required* to get the ThunderXs we have in the FreeBSD cluster to work at all. o.0 I guess "someone" needs to contact "someone" to figure out which is correct or we need to replace our FreeBSD cluster machines with ones that work like the packet.net machines? sean --g7z02vWL7XFIzbuyfh2VKta7p2q26nzWV-- --GvQmRhFURa83tvIVOlxHjsgU37ym3N6yw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAltCKWRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LY2hQf9FZse8++rIG12toi3Eo9hHYje38fRsaisK085mAhrcIsZp252Rr/fFj74 zcygj3X19VSxSuxchKI/1YSlwJM6VA9o51TvcVjwTMKADSImRWxhIX+hgmuhdlIK JTHncLtOvBREtqSuJ/mI3rtfP5NXSRYPnXrC6YUTOHcWYQBr3yLkTrLXDeyjNSLf umRMvIkcC3xxbbctIYyHn9GXfszHoohIqGFUBJfw2dLyp2L9x+oiR2VccSmbZJsu pKuTnFxtDU6RxpjWqDhvn4nx+NdNTVqXpFgu92D/d+2AI8WjNQQTQV5CQzjZIP/H bdKoRtlLo3XDxQX02XMAb8d/BIuObg== =REtC -----END PGP SIGNATURE----- --GvQmRhFURa83tvIVOlxHjsgU37ym3N6yw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ef680451-5750-e0cd-27b5-852fc8e74eb8>