Date: Sat, 13 Feb 2010 12:51:26 -0500 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Masafumi NAKANE <max@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/p5-Log-Dispatch Makefile Message-ID: <4B76E69E.6080800@p6m7g8.com> In-Reply-To: <86fx55wotz.wl%max@wide.ad.jp> References: <201002122334.o1CNYUKF010088@repoman.freebsd.org> <4B75E67B.8020302@p6m7g8.com> <86fx55wotz.wl%max@wide.ad.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/13/2010 2:56 AM, Masafumi NAKANE wrote:
> On Fri, 12 Feb 2010 18:38:35 -0500,
> "Philip M. Gollucci" <pgollucci@p6m7g8.com> wrote:
>>> | .if defined(WITH_APACHELOG)
>>> | .if defined(WITH_APACHE2)
>>> | -RUN_DEPENDS+= mod_perl>=2.0:${PORTSDIR}/www/mod_perl2
>>> | +RUN_DEPENDS+= mod_perl2>=2.0:${PORTSDIR}/www/mod_perl2
>>> | .else
>>> | RUN_DEPENDS+= ${LOCALBASE}/libexec/apache/libperl.so:${PORTSDIR}/www/mod_perl
>>> | .endif
>
>
>> WITH_APACHE2 is deprecated and you use use WITH_APACHE and trigger based
>> on APACHE_VERSION
My comment stands.
.include <bsd.port.option.mk>
.if defined(WITH_APACHE)
.if ${APACHE_VERSION} = 22
.elif ${APACHE_VERSION} = 20
.else # 13
.endif
.endif
iirc www/rt38 and *several* other ports have examples.
>
> Not in this case, I believe. In this case, WITH_APACHE2 is used to
> determine (or rather, let the user define) which version of Apache is
> on the system. If Apache 2.0+ is being used, the port depends on
> mod_perl2, and if it's 1.3, then the dependency is on mod_perl-1.x.
> So, if there's any appropriate way to find out which version of Apache
> is being used on the system, that should replace this part instead,
> but I'm not aware of any such method.
>
> Cheers,
> Max
--
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354
VP Apache Infrastructure; Member, Apache Software Foundation
Committer, FreeBSD Foundation
Sr. System Admin, Ridecharge Inc.
Consultant, P6M7G8 Inc.
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B76E69E.6080800>