Date: Mon, 26 Jan 2015 18:36:19 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Julio Merino <jmmv@meroh.net> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org, Garrett Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r276423 - stable/10/share/mk Message-ID: <96750137-123C-4D51-9EC7-8269D9463AC1@gmail.com> In-Reply-To: <CA2595B7-6D82-478D-BA60-0966D4246F86@meroh.net> References: <201412302046.sBUKk2B3049040@svn.freebsd.org> <CA2595B7-6D82-478D-BA60-0966D4246F86@meroh.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_65845936-61F9-4FBF-97F3-D715BF39BA7C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Dec 31, 2014, at 7:54, Julio Merino <jmmv@meroh.net> wrote: > On Dec 30, 2014, at 21:46, Garrett Cooper <ngie@FreeBSD.org> wrote: >=20 >> Author: ngie >> Date: Tue Dec 30 20:46:01 2014 >> New Revision: 276423 >> URL: https://svnweb.freebsd.org/changeset/base/276423 >>=20 >> Log: >> MFC r274077: >>=20 >> As an optimization (in simple, well used cases) only call cat = ${.ALLSRC} when >> generating files from various sources instead of calling cat = ${.ALLSRC} | sed >=20 > Is there any visible effect to this optimization? Otherwise, the = extra complexity does not seem warranted. Hi Julio! There are a few things to gain from this: 1. Errors with cat=92ing the files are caught when sed transformations = aren=92t applied to the files. 2. Less resources are used in generating the files if sed isn=92t = needed: i. Less forked processes. ii. No pipelines need to be created. I don=92t have numbers for how much faster it is (probably negligible if = done once, potentially more noticeable if done as a micro benchmark), = but I could do this if you like. Thank you! --Apple-Mail=_65845936-61F9-4FBF-97F3-D715BF39BA7C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUxvmjAAoJEMZr5QU6S73euhgH/3VMnKcSOdxtv81nTd78ZfQz 7v5O7dYr0h+kvmXyJoas+NUdrRKp999TK3sUI12lBu2Z2FOZuTS3BWLG11sulq7R H8i1G1GWBXAuWHArvllbgXmeeuVQF9B2gTNtfsG6WjK5KdD+I2z8jtBtJJlP+x3r Y3/FDZ2yFefpBg/6qs4nSnkcSeyPkLZcQoHzmc/X2HiedAPCFzYuhHdsk2NJQTWc 3flH7ielCZpLO+cygULnPv9ZPsZouLwIulaQKhlq7o1mk4DPXCIWkGB5uZiwZqaL CWbyiKDw0TlobYzTI3iMyYVnr8kkXbUUNSlJ/glE0ZSrDbhGNv6i881EOxuKauo= =1JLW -----END PGP SIGNATURE----- --Apple-Mail=_65845936-61F9-4FBF-97F3-D715BF39BA7C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96750137-123C-4D51-9EC7-8269D9463AC1>