Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Nov 2025 13:41:55 -0800
From:      Gleb Smirnoff <glebius@freebsd.org>
To:        Renato Botelho <garga@freebsd.org>
Cc:        "David E. O'Brien" <obrien@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM
Message-ID:  <aReiI9Zrggh0iyW1@cell.glebi.us>
In-Reply-To: <e9235130-e317-4add-b051-53a9c7cb6bc3@FreeBSD.org>
References:  <202511110246.5AB2kdQc077401__35176.4420907543$1762829211$gmane$org@gitrepo.freebsd.org> <e9235130-e317-4add-b051-53a9c7cb6bc3@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail

On Fri, Nov 14, 2025 at 06:03:15PM -0300, Renato Botelho wrote:
R> After upgrading my laptop this morning I noticed it was freezing after
R> suspend/resume.  I've bisected and ended up on this commit.
R> 
R> I confirmed reverting d6f10a5d013f (only to prevent conflicts) followed by
R> f1b9c1aafd84 and 3deb21f1afd5 have fixed the issue.
R> 
R> My system is running today's CURRENT at 82d8a5029a80.

Looks like the commit you point at can't be a culprit.  Looking closer to your
description "reverting d6f10a5d013f followed by f1b9c1aafd84 and 3deb21f1afd5"
it seems that the only functional change is addition of device tpm and
rdrand_rng and option RANDOM_ENABLE_TPM to the GENERIC.

Can you please try unmodified main sources at 82d8a5029a80, but modify GENERIC
to remove these two lines:

+# random(4)
+device         rdrand_rng              # Intel Bull Mountain RNG
+device         tpm                     # Trusted Platform Module
+options        RANDOM_ENABLE_TPM       # enable entropy from TPM 2.0

If that helps, can you please find which particular line makes the
regression.

-- 
Gleb Smirnoff


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aReiI9Zrggh0iyW1>