Date: Sun, 20 Jun 1999 02:54:40 -0700 (PDT) From: Allan Saddi <asaddi@philosophysw.com> To: Frank Tobin <ftobin@bigfoot.com>, kris@further.com Cc: FreeBSD-security Mailing List <freebsd-security@FreeBSD.ORG> Subject: Re: proposed secure-level 4 patch (fwd) Message-ID: <Pine.BSF.4.10.9906200232120.6859-100000@shell2.ba.best.com> In-Reply-To: <Pine.BSF.4.10.9906192320330.66866-300000@srh0710.urh.uiuc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
> here is the no-union-mount-in-secure-mode diff and the tcp diff, which
> should both be against -current.
There are still problems with this no-bind-securelevel patch:
1. It only handles bind requests for tcp. The same modification must be
done to udp_bind() in udp_usrreq.c *OR* you can perform the check
in in_pcbbind() in in_pcb.c. See my previous posting for my patch.
(Which I tested under -stable. Forward-porting to -current should be
trivial.)
2. sinp->sin_port is in network byte order. ntohs() should be used on
it before comparison. Since network order is big-endian, it
surprises me that this patch works. ;)
3. As Brian Buchanan pointed out, port 1024 itself is not privileged.
--
Allan Saddi "The Earth is the cradle of mankind,
asaddi@philosophysw.com but we cannot live in the cradle
http://www.philosophysw.com/asaddi/ forever." - K.E. Tsiolkovsky
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9906200232120.6859-100000>