Date: Mon, 26 Dec 2011 12:32:43 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Justin Hibbits <chmeeedalf@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@FreeBSD.org>, src-committers@freebsd.org Subject: Re: svn commit: r228874 - head/sys/dev/hwpmc Message-ID: <4EF8D9EB.9010506@FreeBSD.org> In-Reply-To: <0AA7AB29-F489-4C8E-BA2A-85DC6788FFC6@gmail.com> References: <201112251429.pBPETawV062695@svn.freebsd.org> <4EF812F4.9010902@FreeBSD.org> <0AA7AB29-F489-4C8E-BA2A-85DC6788FFC6@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/26/2011 04:50, Justin Hibbits wrote: > On Dec 26, 2011, at 1:23 AM, Doug Barton wrote: > >> On 12/25/2011 06:29, Bjoern A. Zeeb wrote: >>> Author: bz >>> Date: Sun Dec 25 14:29:36 2011 >>> New Revision: 228874 >>> URL: http://svn.freebsd.org/changeset/base/228874 >>> >>> Log: >>> Quite the tinderbox for the holidays. Remove the assert[1]. >> >> Shouldn't "Why it's Ok to remove the assert" be part of this commit log? > > When I suggested the removal, I didn't see it as necessary, and was just > looking to quiet the build for now while I look closer. Right now, that > code is never called, as it's only used when configured for sampling, > and that code was originally just a copy from the hwpmc_amd driver. I > will be finishing the sampling code in the new year. Thank you for the explanation. -- [^L] Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EF8D9EB.9010506>