Date: Sat, 5 May 2012 19:39:01 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Doug Barton <dougb@FreeBSD.org> Cc: Baptiste Daroussin <bapt@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, Garrett Cooper <yanegomi@gmail.com>, "svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>, "svn-src-head@freebsd.org" <svn-src-head@FreeBSD.org>, "kmoore@freebsd.org" <kmoore@FreeBSD.org>, Josh Paetzel <jpaetzel@FreeBSD.org> Subject: Re: svn commit: r235005 - head/usr.sbin/pc-sysinstall/backend Message-ID: <20120505192318.T1202@besplex.bde.org> In-Reply-To: <4FA438C4.3080701@FreeBSD.org> References: <201205041531.q44FVaYF010236@svn.freebsd.org> <F68AFF89-B9C3-494B-8B61-7130999BC354@gmail.com> <20120504182200.GD1604@azathoth.lan> <4FA438C4.3080701@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 4 May 2012, Doug Barton wrote:
> On 05/04/2012 11:22 AM, Baptiste Daroussin wrote:
>>>>>> fetch -s "${FETCHFILE}" >${SIZEFILE}
>>>>>> SIZE="`cat ${SIZEFILE}`"
>>>>>> - SIZE="`expr ${SIZE} / 1024`"
>>>>>> + SIZE=$((SIZE/1024))
>>>>
>>>> Bug; should be '$SIZE/'
>> No this is perfectly valid
>
> Yes, that works, but it's not our usual style. However, the point is
> moot as that whole block should be reduced down to:
>
> SIZE=$(( `fetch -s "${FETCHFILE}"` / 1024 ))
The KNF rule that there shall be spaces around binary operators should
probably apply in shell expressions too, but I don't like the spaces
on 1 side of (( and )). Shell syntax doesn't even allow spaces between
'$' ((.
The rc.d style seems to be to use backquotes and not use $(cmd), but I
prefer the opposite except possibly in shell expressions like the above
so that it is easier to separate the commands from the shell expressions.
> If SIZEFILE is needed elsewhere that's a different matter, but as it is
> that's a hot mess.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120505192318.T1202>