Date: Mon, 18 Jan 1999 07:50:50 +0800 From: Peter Wemm <peter@netplex.com.au> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/net if_tun.c ppp_tty.c src/sys/modules/if_tun Makefile src/sys/modules/if_ppp Makefile Message-ID: <199901172350.HAA07539@spinner.netplex.com.au> In-Reply-To: Your message of "Mon, 18 Jan 1999 10:34:38 %2B1100." <199901172334.KAA02595@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > > Modified files: > > sys/net if_tun.c ppp_tty.c > > sys/modules/if_tun Makefile > > sys/modules/if_ppp Makefile > > Log: > > Undo #undef KERNEL hack for vnode.h to avoid vnode_if.h. > > XXX It probably makes sense to have a flag for bsd.kern.mk to avoid these > > rules. > > You mean bsd.kmod.mk. Yep. :-) > VFS_LKM/VFS_KLD does it it for vfs LKM^H^H^HKLDs (KLD is a bad name). I agree, but we can't have two different thigns with the same name. Once the old lkm's are truely gone, then we can choose better terminology for them. > > XXX IO_NDELAY seems to be the main reason for it, when used in a cdevsw > > read or write "flag" context. Perhaps a redundant declaration > > somewhere like sys/conf.h might help remove the need for vnode.h in > > these device drivers in the first place. > > Perhaps just move the definitions. The IO_ flags don't seem to have > anything to do with vnodes. It's the argument for VOP_READ()/VOP_WRITE() etc. It is a vnode flag, but specfs passes it down to the drivers. > Bruce Cheers, -Peter To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901172350.HAA07539>