Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 17 Apr 2021 01:21:12 GMT
From:      Kevin Bowling <kbowling@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 21afed4b1d18 - main - ixgbe: Clarify index name in ixgbe_mc_filter_apply
Message-ID:  <202104170121.13H1LCNC033115@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kbowling (ports committer):

URL: https://cgit.FreeBSD.org/src/commit/?id=21afed4b1d18578aa8c9fa31e9e677971f8b4300

commit 21afed4b1d18578aa8c9fa31e9e677971f8b4300
Author:     Kevin Bowling <kbowling@FreeBSD.org>
AuthorDate: 2021-04-17 01:17:43 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2021-04-17 01:20:41 +0000

    ixgbe: Clarify index name in ixgbe_mc_filter_apply
    
    "It looks like it would be less confusing to rename 'count' to
    something like 'idx', since that's what it's used for in this
    function."
    
    Reviewed by:    erj
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D29798
---
 sys/dev/ixgbe/if_ix.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
index 6e65f6bae55a..77ef118493a2 100644
--- a/sys/dev/ixgbe/if_ix.c
+++ b/sys/dev/ixgbe/if_ix.c
@@ -3262,15 +3262,15 @@ ixgbe_config_delay_values(struct adapter *adapter)
  *   Called whenever multicast address list is updated.
  ************************************************************************/
 static u_int
-ixgbe_mc_filter_apply(void *arg, struct sockaddr_dl *sdl, u_int count)
+ixgbe_mc_filter_apply(void *arg, struct sockaddr_dl *sdl, u_int idx)
 {
 	struct adapter *adapter = arg;
 	struct ixgbe_mc_addr *mta = adapter->mta;
 
-	if (count == MAX_NUM_MULTICAST_ADDRESSES)
+	if (idx == MAX_NUM_MULTICAST_ADDRESSES)
 		return (0);
-	bcopy(LLADDR(sdl), mta[count].addr, IXGBE_ETH_LENGTH_OF_ADDRESS);
-	mta[count].vmdq = adapter->pool;
+	bcopy(LLADDR(sdl), mta[idx].addr, IXGBE_ETH_LENGTH_OF_ADDRESS);
+	mta[idx].vmdq = adapter->pool;
 
 	return (1);
 } /* ixgbe_mc_filter_apply */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104170121.13H1LCNC033115>