Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 Nov 2022 14:19:26 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 4718d86b3b1a - stable/13 - ssh: correct parse_cert_times case for hex "to" time
Message-ID:  <202211061419.2A6EJQ48069112@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=4718d86b3b1aac3f58c19fce34932fd88486af94

commit 4718d86b3b1aac3f58c19fce34932fd88486af94
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2022-11-03 13:44:52 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-11-06 14:19:02 +0000

    ssh: correct parse_cert_times case for hex "to" time
    
    This appeared to be a copy-paste error from the "from" time case above.
    
    Reported by:    Coverity Scan
    CID:            1500407
    Reviewed by:    markj
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D37252
    
    (cherry picked from commit 0657b2325df3d85967870a928d58b24ffcf3f1ea)
---
 crypto/openssh/ssh-keygen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/openssh/ssh-keygen.c b/crypto/openssh/ssh-keygen.c
index 9b2beda05f0c..1255957d0e67 100644
--- a/crypto/openssh/ssh-keygen.c
+++ b/crypto/openssh/ssh-keygen.c
@@ -1975,7 +1975,7 @@ parse_cert_times(char *timespec)
 		cert_valid_to = parse_relative_time(to, now);
 	else if (strcmp(to, "forever") == 0)
 		cert_valid_to = ~(u_int64_t)0;
-	else if (strncmp(from, "0x", 2) == 0)
+	else if (strncmp(to, "0x", 2) == 0)
 		parse_hex_u64(to, &cert_valid_to);
 	else if (parse_absolute_time(to, &cert_valid_to) != 0)
 		fatal("Invalid to time \"%s\"", to);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202211061419.2A6EJQ48069112>